Skip to content
This repository has been archived by the owner on May 4, 2023. It is now read-only.

Examples: contourApproach depends on envSampling modifying NDBC46022.h5 #39

Open
ssolson opened this issue May 28, 2020 · 1 comment
Open
Labels
cleanup management WDRT code management

Comments

@ssolson
Copy link
Contributor

ssolson commented May 28, 2020

example_contourApproach.py requires that example_envSampling.py has run and modified NDBC46022.h5.

This creates a required order to run the examples which is not clear to the intended audience (e.g. a new user). Further, while the user can specify the output H5 file name the duplication of the full buoy dataset does not seem ideal (e.g. the user now has 2 files of buoy data only differing by one having contour output from running example_envSampling.py). Finally, I believe this modification of the H5 file in place contributed to #29

I propose to address these issues and prevent future ones we:

  1. Remove any dependency between examples
  2. Restructure how we save contour data (e.g. I think we should look into having results separate from input)
@ssolson ssolson added bug WDRT does not run cleanup management WDRT code management labels May 28, 2020
@ssolson
Copy link
Contributor Author

ssolson commented May 28, 2020

PR #36 established the data default locations expecting the user to run the examples from the examples folder. E.g. each example now has a relative path pointing to the repository example data.

@ssolson ssolson removed the bug WDRT does not run label May 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cleanup management WDRT code management
Projects
None yet
Development

No branches or pull requests

1 participant