Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metadata inconsistency during pip installation process #11

Open
AlexGherardelli opened this issue Nov 8, 2023 · 3 comments
Open

Metadata inconsistency during pip installation process #11

AlexGherardelli opened this issue Nov 8, 2023 · 3 comments

Comments

@AlexGherardelli
Copy link
Collaborator

Installing it with command pip install pip@git+https://github.com/WFP-VAM/DataBridgesAPI result in error (see log):

Collecting pip@ git+https://github.com/WFP-VAM/DataBridgesAPI
  Cloning https://github.com/WFP-VAM/DataBridgesAPI to c:\users\alessandra.gherardel\appdata\local\temp\pip-install-_8ayfm8h\pip_c893ebad5a2a43b6ba81ef1d1b9d608e
  Resolved https://github.com/WFP-VAM/DataBridgesAPI to commit 7d82d71eee5fd9e4a9bbe0899a6be29ccd547204
  Installing build dependencies: started
  Installing build dependencies: finished with status 'done'
  Getting requirements to build wheel: started
  Getting requirements to build wheel: finished with status 'done'
  Preparing metadata (pyproject.toml): started
  Preparing metadata (pyproject.toml): finished with status 'done'
Discarding git+https://github.com/WFP-VAM/DataBridgesAPI: Requested databridgesapi from git+https://github.com/WFP-VAM/DataBridgesAPI has inconsistent name: expected 'pip', but metadata has 'databridgesapi'

@mcarans
Copy link

mcarans commented Feb 29, 2024

@ValerioGiuffrida

I ran into this too. In my pyproject.toml, to have this library be an optional dependency, I had to include it like this:

[project.optional-dependencies]
wfp = ["data-bridges-client@git+https://github.com/WFP-VAM/DataBridgesAPI@dev#egg=data-bridges-client"]

In a requirements.txt file, it looks like this:
data-bridges-client@git+https://github.com/WFP-VAM/DataBridgesAPI@dev

@paololucchino
Copy link
Member

Hi @mcarans, please note that the former dev branch has now been merged and tagged here https://github.com/WFP-VAM/DataBridgesAPI/releases/tag/v2.0.0. This will require some minor changes to your pyproject.toml and requirements.txt.

@AlexGherardelli the release link details installation instructions. This should fix the issues you reported, and we should be able to close this issue.

@mcarans
Copy link

mcarans commented Mar 15, 2024

@paololucchino Please can you make a release to pypi as it is not possible to use GitHub dependencies in libraries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants