Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CreateWillRecoveryProject should check whether the recovery is needed #514

Open
Xymanek opened this issue May 2, 2020 · 0 comments
Open
Labels
bug Something isn't working enhancement Improvement of something that already exists good first issue Good for newcomers
Milestone

Comments

@Xymanek
Copy link
Member

Xymanek commented May 2, 2020

static function CreateWillRecoveryProject(XComGameState NewGameState, XComGameState_Unit UnitState)
{
local XComGameState_HeadquartersProjectRecoverWill WillProject;
local XComGameState_HeadquartersXCom XComHQ;
XComHQ = class'X2StrategyElement_DefaultMissionSources'.static.GetAndAddXComHQ(NewGameState);
WillProject = XComGameState_HeadquartersProjectRecoverWill(NewGameState.CreateNewStateObject(class'XComGameState_HeadquartersProjectRecoverWill'));
WillProject.SetProjectFocus(UnitState.GetReference(), NewGameState);
XComHQ.Projects.AddItem(WillProject.GetReference());
}

The function above s called from various places where CI restarts will recovery, but currently it can create recovery projects for people who don't need them, thus causing either warnings or subtle bugs

@Xymanek Xymanek added bug Something isn't working enhancement Improvement of something that already exists labels May 2, 2020
@Xymanek Xymanek added this to the Beta 3 milestone May 2, 2020
@Xymanek Xymanek modified the milestones: Beta 3, Beta 3.1 May 5, 2020
@Xymanek Xymanek added the good first issue Good for newcomers label Jun 24, 2020
@Xymanek Xymanek modified the milestones: Beta 3.1, Beta 3.2 Jul 20, 2020
@Xymanek Xymanek modified the milestones: Beta 3.2, Post release Jul 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement Improvement of something that already exists good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant