[Core] Networking error publisher #1070
Conversation
flypaper0
force-pushed
the
feature/notworking-error-publisher
branch
from
4d01f54 to
71c9886
Compare
|
|
||
| logger.debug("Received Notify Message on topic: \(payload.topic)", properties: ["topic": payload.topic]) | ||
| let (messagePayload, claims) = try NotifyMessagePayload.decodeAndVerify(from: payload.request) |
There was a problem hiding this comment.
if this throws will it be handled in Networking Client?
if so, isn't it strange that lower level client handles higher level client's errors?
There was a problem hiding this comment.
Networking client not handling, just aggregating. Handling will be in Networking client publisher's subscribers
There was a problem hiding this comment.
I see, the idea of having the "catch block" is really good but to me it's still strange that for expample:
in notify engine in networkingInteractor.subscribeOnRequest block let's say function throws a notify specific error.
for example "notify subscription not found" or whatever and that error is passed down to Networking Client.
so let's say later an app want's to listen to networking only errors and it gets "notify subscription not found"
don't you think something smells here?
There was a problem hiding this comment.
I think it is the only way to have single error publisher. Depends on what we trying to acheive. By that PR I want to reduce error handling code for SDK's. One thing. May be we can delete error publisher for now and only log inside catch block?
There was a problem hiding this comment.
because we are mostly just logging errors
There was a problem hiding this comment.
I am still not convinced 🤔
flypaper0
force-pushed
the
feature/notworking-error-publisher
branch
from
1c5cee4 to
e4d8ec8
Compare
No description provided.