Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Core] ClientID public and private part #1079

Merged
merged 10 commits into from
Oct 9, 2023
Merged

[Core] ClientID public and private part #1079

merged 10 commits into from
Oct 9, 2023

Conversation

flypaper0
Copy link
Contributor

No description provided.

@flypaper0 flypaper0 requested a review from llbartekll September 7, 2023 09:21
@flypaper0 flypaper0 temporarily deployed to internal September 7, 2023 09:21 — with GitHub Actions Inactive
@flypaper0 flypaper0 temporarily deployed to internal September 7, 2023 11:16 — with GitHub Actions Inactive
@flypaper0 flypaper0 temporarily deployed to internal September 7, 2023 11:58 — with GitHub Actions Inactive
@flypaper0 flypaper0 temporarily deployed to internal September 7, 2023 12:05 — with GitHub Actions Inactive
@flypaper0 flypaper0 force-pushed the feature/clienid-from-defaults branch from 5114f1e to e22efda Compare September 7, 2023 13:47
@flypaper0 flypaper0 temporarily deployed to internal September 7, 2023 13:47 — with GitHub Actions Inactive
llbartekll
llbartekll approved these changes Sep 12, 2023
View reviewed changes
Copy link
Contributor

@llbartekll llbartekll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I would just test it manually before releasing.
will let you know when I try it

@flypaper0 flypaper0 force-pushed the feature/clienid-from-defaults branch from e22efda to b01f6ac Compare September 15, 2023 09:24
@flypaper0 flypaper0 temporarily deployed to internal September 15, 2023 09:25 — with GitHub Actions Inactive
@flypaper0 flypaper0 force-pushed the feature/clienid-from-defaults branch from b01f6ac to a2e7330 Compare October 3, 2023 11:36
@flypaper0 flypaper0 temporarily deployed to internal October 3, 2023 11:36 — with GitHub Actions Inactive
@flypaper0 flypaper0 temporarily deployed to internal October 3, 2023 12:32 — with GitHub Actions Inactive
@flypaper0 flypaper0 temporarily deployed to internal October 4, 2023 09:58 — with GitHub Actions Inactive
@flypaper0 flypaper0 temporarily deployed to internal October 4, 2023 12:11 — with GitHub Actions Inactive
@flypaper0 flypaper0 temporarily deployed to internal October 4, 2023 12:48 — with GitHub Actions Inactive
@flypaper0 flypaper0 linked an issue Oct 6, 2023 that may be closed by this pull request
[Notify Beta.1] Lost & duplicate messages #1160
Closed
@flypaper0
Copy link
Contributor Author

@llbartekll manual Testing notes:

1. Running old version (before ClientID parts)

-- before uninstall
did:key:z6MkuKdht2idaKzZbAQBjApre2zgHFiKEro5xj5gAwbQCuZS

-- after uninstall (NOT CHANGED)
did:key:z6MkuKdht2idaKzZbAQBjApre2zgHFiKEro5xj5gAwbQCuZS

2. Updating to new version (with ClientID parts)

-- before uninstall
did:key:z6MkuKdht2idaKzZbAQBjApre2zgHFiKEro5xj5gAwbQCuZS

-- after uninstall (CHANGED)
did:key:z6MktYUSQsEoXNea2S82VX4NroawtepTa4WkbBNbdmqgKymr

@flypaper0 flypaper0 force-pushed the feature/clienid-from-defaults branch from dbbcd39 to 4fd6d9b Compare October 9, 2023 06:06
@flypaper0 flypaper0 temporarily deployed to internal October 9, 2023 06:06 — with GitHub Actions Inactive
@flypaper0 flypaper0 temporarily deployed to internal October 9, 2023 06:28 — with GitHub Actions Inactive
@llbartekll
Copy link
Contributor

@llbartekll manual Testing notes:

1. Running old version (before ClientID parts)

-- before uninstall
did:key:z6MkuKdht2idaKzZbAQBjApre2zgHFiKEro5xj5gAwbQCuZS

-- after uninstall (NOT CHANGED)
did:key:z6MkuKdht2idaKzZbAQBjApre2zgHFiKEro5xj5gAwbQCuZS

2. Updating to new version (with ClientID parts)

-- before uninstall
did:key:z6MkuKdht2idaKzZbAQBjApre2zgHFiKEro5xj5gAwbQCuZS

-- after uninstall (CHANGED)
did:key:z6MktYUSQsEoXNea2S82VX4NroawtepTa4WkbBNbdmqgKymr

did you try for "cold start" - user has never installed the app before. (clean simulator or cleaned keychain)

@flypaper0 flypaper0 merged commit c17686e into develop Oct 9, 2023
8 checks passed
@flypaper0 flypaper0 deleted the feature/clienid-from-defaults branch October 9, 2023 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@llbartekll llbartekll llbartekll approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Notify Beta.1] Lost & duplicate messages
2 participants
@flypaper0 @llbartekll