Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Notify] Sample Subscription and Preferences screens #1123

Merged
merged 6 commits into from
Sep 20, 2023
Merged

[Notify] Sample Subscription and Preferences screens #1123

merged 6 commits into from
Sep 20, 2023

Conversation

flypaper0
Copy link
Contributor

Description

Resolves # (issue)

How Has This Been Tested?

Due Dilligence

  • Breaking change
  • Requires a documentation update

@flypaper0 flypaper0 temporarily deployed to internal September 19, 2023 19:49 — with GitHub Actions Inactive
@flypaper0 flypaper0 temporarily deployed to internal September 19, 2023 20:04 — with GitHub Actions Inactive
llbartekll
llbartekll approved these changes Sep 20, 2023
View reviewed changes
Copy link
Contributor

@llbartekll llbartekll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work!
we could probably rename some classes like PushMessagesInteractor to notify

@llbartekll
Copy link
Contributor

also from the screen recording I can see that images are not cashed and they appear black first on every scroll up and down

@flypaper0 flypaper0 force-pushed the feature/notify-sample-part-2 branch from e93ba8a to c1ef1f0 Compare September 20, 2023 12:50
@flypaper0 flypaper0 temporarily deployed to internal September 20, 2023 12:51 — with GitHub Actions Inactive
@flypaper0 flypaper0 merged commit e41c2d0 into develop Sep 20, 2023
8 checks passed
@flypaper0 flypaper0 deleted the feature/notify-sample-part-2 branch September 20, 2023 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@llbartekll llbartekll llbartekll approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@flypaper0 @llbartekll