[Relay] Authenticator Fix #1124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-lsvk
temporarily deployed
to
internal
GitHub Actions
Inactive
alexander-lsvk
temporarily deployed
to
internal
GitHub Actions
Inactive
alexander-lsvk
temporarily deployed
to
internal
GitHub Actions
Inactive
flypaper0
reviewed
Oct 2, 2023
|
|
||
| public init(clientIdStorage: ClientIdStoring, url: String) { | ||
| self.clientIdStorage = clientIdStorage | ||
| self.url = url | ||
| } | ||
|
|
||
| public func createAuthToken() throws -> String { | ||
| public func createAuthToken(url: String? = nil) throws -> String { | ||
| url.flatMap { self.url = $0 } |
There was a problem hiding this comment.
why we're rewriting class instance?
There was a problem hiding this comment.
if it enough to just use and not change class state??
let audience = fallbackUrl ?? url
There was a problem hiding this comment.
@flypaper0 it was like that before, but Bartek asked to change the url inside the object.
class is to make it mutable, I don't wanna have a mutable struct there
flypaper0
approved these changes
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves # (issue)
How Has This Been Tested?
Due Dilligence