Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Notify] AppPubKey for subscription / subscriptionChange subscriber fixed #1200

Merged
merged 7 commits into from
Oct 29, 2023

Conversation

flypaper0
Copy link
Contributor

No description provided.

@flypaper0 flypaper0 requested a review from llbartekll October 27, 2023 16:37
@flypaper0 flypaper0 temporarily deployed to internal October 27, 2023 16:37 — with GitHub Actions Inactive
@flypaper0 flypaper0 temporarily deployed to internal October 27, 2023 19:33 — with GitHub Actions Inactive
@@ -132,6 +132,11 @@ public class NotifyClient {

#if targetEnvironment(simulator)
extension NotifyClient {

public var subscriptionChangedPublisher: AnyPublisher<[NotifySubscription], Never> {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didn't we want to make this one internal?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I decided to make it public because we have #if targetEnvironment(simulator) check

@flypaper0 flypaper0 temporarily deployed to internal October 28, 2023 12:21 — with GitHub Actions Inactive
@flypaper0 flypaper0 temporarily deployed to internal October 29, 2023 17:55 — with GitHub Actions Inactive
@flypaper0 flypaper0 merged commit f834829 into develop Oct 29, 2023
8 checks passed
@flypaper0 flypaper0 deleted the feature/dapp-pub-key-for-subscription branch October 29, 2023 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants