Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Play embedded youtube videos within the docs #1394

Open
yahiheb opened this issue Dec 8, 2022 · 2 comments
Open

Play embedded youtube videos within the docs #1394

yahiheb opened this issue Dec 8, 2022 · 2 comments

Comments

@yahiheb
Copy link
Collaborator

yahiheb commented Dec 8, 2022

The videos now open up a new tab in YouTube. They used to be embedded and play within the docs.

#1247 (comment)
#1247 (comment)

Possible solution: vuepress/core#1182

@jesseaam
Copy link
Contributor

Possible solution: vuepress/core#1182

I think this would be a great solution, though I've been having trouble getting it to work. When you install the plugin vuepress-plugin-components@next it causes the docs not to show up anymore.

Documentation

Running the current master this is what you see when you start the development server:
npm start

> wasabidoc@0.1.0 prestart
> rm -rf $npm_package_config_dist


> wasabidoc@0.1.0 start
> vuepress dev docs

warning an anonymous plugin or theme was detected and ignored
warning an anonymous plugin or theme was detected and ignored
warning an anonymous plugin or theme was detected and ignored
✔ Initializing and preparing data - done in 986ms

  vite v3.1.8 dev server running at:

  ➜  Local:   http://localhost:8080/
Now install the plugin:
$ npm i -D vuepress-plugin-components@next

added 326 packages, removed 2 packages, changed 24 packages, and audited 795 packages in 21s

78 packages are looking for funding
  run `npm fund` for details

6 vulnerabilities (2 moderate, 4 high)

To address issues that do not require attention, run:
  npm audit fix

Some issues need review, and may require choosing
a different dependency.

Run `npm audit` for details.
Running the current master AFTER INSTALLING PLUGIN this is what you see when you start the development server:
$ npm start

> wasabidoc@0.1.0 prestart
> rm -rf $npm_package_config_dist


> wasabidoc@0.1.0 start
> vuepress dev docs

warning an anonymous plugin or theme was detected and ignored
warning an anonymous plugin or theme was detected and ignored
warning an anonymous plugin or theme was detected and ignored
✔ Initializing and preparing data - done in 1.19s

  vite v4.0.0 dev server running at:

  ➜  Local:   http://localhost:8080/

In short the difference you see is before and after installing the plugin:

  • vite v3.1.8 dev server running at:
  • vite v4.0.0 dev server running at:

I started a discussion here on GitHub Discussions, so maybe the community there will have some tips.

@MarnixCroes
Copy link
Collaborator

What's the status of this?
@CAnorbo any ideas?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants