Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discard new install in addon on "ready for install" click #1475

Open
mrbuds opened this issue Jul 5, 2022 · 3 comments
Open

Discard new install in addon on "ready for install" click #1475

mrbuds opened this issue Jul 5, 2022 · 3 comments
Labels
bug Something isn't working

Comments

@mrbuds
Copy link
Contributor

mrbuds commented Jul 5, 2022

My interpretation of a suggetion by Vardex 18/05/2k22 in discord companion app dev channel for a better workflow of "Ready for Install"

Issue

After clicking install button and install aura, aura keep showing in weakauras list until it's wiped in app and /reload in game

Implementation

Addon:

  • On install from "ready for install" mark "slug" as installed and hide it from this section WeakAurasData.Installed[slug] = true
  • After WeakAuras.AddCompanionData, clear of WeakAurasData.Installed slugs missing

App:

  • When app refresh data, clean from stash everything in WeakAurasData.Installed
  • Alternatively, clear stash on every refresh (that's what CB or vardex thing does i guess)

Thoughts:

  • When installing a new aura we need to know data is coming from "ready for install" to mark it
  • WeakAuras.AddCompanionData can be called multiple times if more than one updater addon is installed, so how to handle when to remove "installed" flag? (doing it first time opening wa option would work)
@mrbuds mrbuds added the bug Something isn't working label Jul 5, 2022
@billriess
Copy link

I'm getting this same issue.

@keeehlan
Copy link

keeehlan commented Mar 4, 2023

Same issue, surprised that this hasn't been fixed.

@mrbuds
Copy link
Contributor Author

mrbuds commented Mar 4, 2023

Same issue, surprised that this hasn't been fixed.

It's low priority as a simple /reload fixes it and it's not simple to do right, otherwise if a /reload doesn't work you'r talking about a different issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants