-
Notifications
You must be signed in to change notification settings - Fork 737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use IRBuilder in the binary reader #6614
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The new wat parser is based on the
IRBuilder
utility, which maintains all the state necessary to turn a linear sequence of instructions and delimiters into Binaryen IR. The binary reader has its own similar functionality, so we could reduce duplication and improve the quality of the parsed IR if we had it useIRBuilder
instead.Using IRBuilder in both the text and binary parsers will also let us implement new IR building functionality just once in the future. For example, we could support lowering multivalue block input (#6407) to scratch locals just once in IRBuilder rather than having to do it separately for the text and binary parsers.
The text was updated successfully, but these errors were encountered: