Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow multiple patterns for noinline #6646

Closed
DirtyHairy opened this issue Jun 8, 2024 · 3 comments
Closed

Allow multiple patterns for noinline #6646

DirtyHairy opened this issue Jun 8, 2024 · 3 comments

Comments

@DirtyHairy
Copy link
Contributor

I have multiple function patterns that I would like to exclude from inlining. Unfortunately, the noinline pass only allows a single pattern, which does not allow any conditionals. It would be great if there were a way to specify multiple patterns, either by extending the pattern syntax or by allowing multiple instances of the noinline pass.

I can provide a PR for either of these options if desired 😏

@kripken
Copy link
Member

kripken commented Jun 10, 2024

Sounds reasonable to me. Maybe see if there's a simple way to allow multiple instances of the noinline pass, as that sounds best (but I'm not sure how simple it would be, offhand - we'd need to track the pass argument per instance of the pass, I guess).

@DirtyHairy
Copy link
Contributor Author

Alright, I'll look into it.

@DirtyHairy
Copy link
Contributor Author

I opened #6687 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants