-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
directory-entry-stream read batching #142
Comments
Yes, this makes sense to look into. The current iterator API is inspired by POSIX |
When this was originally raised it was based on performance benchmarking, which was later clarified to not be using the Wasmtime compliation cache when running the component benchmarks - when enabled the benchmarks demonstrated equality with preview1 and less call overhead. @dbaeumer do you think this is something that should still be a priority for consideration to provide a noticeable performance improvement? |
@guybedford for VS Code this is not necessary anymore. The performance problem raised from the fact that we add to do a context switch for every read. I decided to but the result in shared memory to avoid such a context switch. However other implementation might hit the same problem. But from the VS Code side this can be closed |
This was originally brought up by @dbaeumer - having to have a function call per directory entry to read through the directory entry stream might introduce unnecessary performance costs for iterating large directories.
It could be useful to have the ability to fetch a chunked list by specifying a
read
variant that takes some kind of upper chunk limit of directory counts at a time to batch reads together.The text was updated successfully, but these errors were encountered: