Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Postage: add support for recipient variables #45

Open
bakura10 opened this issue Aug 24, 2013 · 2 comments
Open

Postage: add support for recipient variables #45

bakura10 opened this issue Aug 24, 2013 · 2 comments

Comments

@bakura10
Copy link
Contributor

While doing a quick overview of what's new in all the API we support, I realized that Postage support variables per recipient. We only support global variables. (Reference: http://help.postageapp.com/kb/api/send_message)

I suggest:

  • Renaming getVariables to getGlobalVariables (as in Mandrill, and because it makes sense)
  • Adding a getVariables which take recipient address as first parameter (as in Mandrill).

As this is a BC, we may do it for 2.0 (I don't think it's a big deal to iterate quickly, as SlmMail is really working well, I see no problem at quickly having another major version for such things).

@juriansluiman
Copy link
Contributor

What's the status of this? Hasn't there been a PR which already addresses this feature?

@roelvanduijnhoven
Copy link
Collaborator

I'll add as an enhancement! One can look at the Mandrill adapter for inspiration how to implement this.

@roelvanduijnhoven roelvanduijnhoven removed this from the v2.0.0 milestone Jan 30, 2020
@roelvanduijnhoven roelvanduijnhoven changed the title Add support for recipient Variables in Postage Postage: add support for recipient variables Jan 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants