Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add conditional probes #466

Merged
merged 5 commits into from
Sep 16, 2024
Merged

Conversation

st-myk
Copy link
Contributor

@st-myk st-myk commented Sep 15, 2024

Proposed changes

Checklist

  • Lint and unit tests pass locally with my changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added documentation to describe my feature.
  • I have squashed my commits into logic units.
  • I have described the changes in the commit messages.

Other information

Summary by CodeRabbit

  • New Features
    • Updated version number to 0.5.12, indicating a new release that may include enhancements or bug fixes.
  • Documentation
    • Revised version number in the README to reflect the new release.
  • Configuration Changes
    • Adjusted deployment configurations for liveness and readiness probes for improved flexibility.
    • Added comments in the values file to clarify the optional nature of probe configurations.

Copy link

coderabbitai bot commented Sep 15, 2024

Walkthrough

The pull request introduces updates focused on versioning and deployment configurations for the Weblate application. The version number in both the Chart.yaml and README.md files has been incremented from 0.5.11 to 0.5.12. Additionally, the deployment configuration has modified the conditional logic for liveness and readiness probes, changing from a "with" context to an "if" condition. The values.yaml file now includes comments regarding the optional removal of probe configurations.

Changes

File Change Summary
charts/weblate/Chart.yaml Version updated from 0.5.11 to 0.5.12.
charts/weblate/README.md Version updated from 0.5.11 to 0.5.12; application version remains 5.7.2.1.
charts/weblate/templates/deployment.yaml Changed conditional logic for liveness and readiness probes from {{- with ... }} to {{- if ... }}.
charts/weblate/values.yaml Added comments about removing livenessProbe and readinessProbe configurations when not in use.

Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 3cd3caf and e76538c.

Files selected for processing (1)
  • charts/weblate/values.yaml (1 hunks)
Files skipped from review as they are similar to previous changes (1)
  • charts/weblate/values.yaml

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@st-myk st-myk marked this pull request as ready for review September 15, 2024 13:57
charts/weblate/values.yaml Outdated Show resolved Hide resolved
charts/weblate/values.yaml Outdated Show resolved Hide resolved
Co-authored-by: Michal Čihař <michal@cihar.com>
@nijel nijel merged commit f4ac690 into WeblateOrg:main Sep 16, 2024
6 checks passed
@nijel
Copy link
Member

nijel commented Sep 16, 2024

Merged, thanks for your contribution!

@notz
Copy link

notz commented Sep 17, 2024

@nijel Are you sure this is working as expected? We get the k8s default liveness probes and because of this containers are not starting after this changes (they are killed before startup finished -> no delay seconds). Helm liveness values seems not to be applied any more.

@Mart-Kuc Mart-Kuc mentioned this pull request Sep 17, 2024
2 tasks
@nijel
Copy link
Member

nijel commented Sep 18, 2024

@notz Apparently it is not, but I didn't spot issue in it because I lack Kubernetes knowledge. It is now fixed via #467 thanks to @Mart-Kuc.

This repository is looking for maintainers, see #348

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants