Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explain e-mail use for commits more transparently #10352

Closed
Cerno-b opened this issue Nov 4, 2023 · 6 comments · Fixed by #10356
Closed

Explain e-mail use for commits more transparently #10352

Cerno-b opened this issue Nov 4, 2023 · 6 comments · Fixed by #10356
Assignees
Labels
enhancement Adding or requesting a new feature.
Milestone

Comments

@Cerno-b
Copy link

Cerno-b commented Nov 4, 2023

Describe the problem

So currently there are two e-mail fields:

  • E-mail (Choose primary e-mail from verified addresses.)
  • Commit e-mail (Choose commit e-mail from verified addresses.)

This could intuitively be understood as "e-mail is for my account and only the commit e-mail is for commits" (if left empty there is no e-mail used in the commits).

But what happens instead is that if the commit e-mail field is empty, then the e-mail becomes the commit e-mail, (at least for po-file exports) which is not very transparent.

It becomes a bigger problem because once you add a translation without setting the commit e-mail field, Weblate will internally store your e-mail and use that in any po export. This will even happen if you change your commit e-mail later, so a user who once fell into the trap outlined above, will have their e-mail locked into the weblate database with no way to remove/change it. Of course addresses can be changed, but in a po export, both e-mail addresses will appear.

I'm not a laywer, but personal data transparency could become a GDPR issue.

Describe the solution you'd like

Short notice: Add some very transparent text blocks to the Profile/Account page, explaining what happens with the e-mail addresses you enter, and potentially a warning that your e-mail address could potentially turn up publicly in the project's git repo that you are contributing to if you fill the fields incorrectly.

This is just a band-aid though, see below for better alternatives.

Describe alternatives you've considered

Longer term: Add an option to edit your personal data that is stored inside the Weblate database with the option to remove/change your address after it has been added. This would solve the problem that someone could have missed the info block and still added an e-mail address they want removed or updated later.

Alternative longer term: Link the e-mail address to the account and propagate any changes on the account page to the database, so that if someone modifies their e-mail address, it will also be updated in the database. Current behavior is to just add new addresses while keeping the old ones in the database

Additional option: Give a user the option to keep their address anonymous, e.g. if no commit address is given. This could either be an omission of the email address or an anonymization like a***.b***@gmail.com. In addition to user choice this could also be a global setting for admins to set if they don't want any trouble with GDPR whatsoever, so they can avoid committing any personal information to their project repo.

Screenshots

No response

Additional context

No response

@nijel
Copy link
Member

nijel commented Nov 5, 2023

I'm not a laywer, but personal data transparency could become a GDPR issue.

That's why there are terms of service on our service, which clearly state this usage of e-mail. We state this also in the overview so that you don't read the full terms to understand this.

Longer term: Add an option to edit your personal data that is stored inside the Weblate database with the option to remove/change your address after it has been added. This would solve the problem that someone could have missed the info block and still added an e-mail address they want removed or updated later.

Alternative longer term: Link the e-mail address to the account and propagate any changes on the account page to the database, so that if someone modifies their e-mail address, it will also be updated in the database. Current behavior is to just add new addresses while keeping the old ones in the database

There is just a single place where Weblate stores user e-mail in the database and that's the profile. The commits are not stored in Weblate, but instead in Git (or Mercurial) and pushed to the upstream repos. And there is effectively no way to change what has been pushed out of Weblate. This has been heavily discussed at #9969, so please read that first.

In addition to user choice this could also be a global setting for admins to set if they don't want any trouble with GDPR whatsoever, so they can avoid committing any personal information to their project repo.

There already is such setting: https://docs.weblate.org/en/latest/admin/config.html#private-commit-email-opt-in. See also https://docs.weblate.org/en/latest/user/profile.html#profile

@Cerno-b
Copy link
Author

Cerno-b commented Nov 5, 2023

Ok, I guess it probably wouldn't hurt to add another warning/disclaimer in the profile page, in case people didn't pay attention to the terms, but I understand your argument that it's documented enough.

What I didn't know is that Weblate uses a local repo for saving the state of translations. Is this something that runs privately inside weblate hosted or is it a public repo? I was probably a bit confused because Godot uses its own repo for keeping translations, which it syncs manually.

I didn't know there was a setting like that, but I understand it's global on Weblate hosted and not changeable per-project?

nijel added a commit that referenced this issue Nov 6, 2023
- for sites with legal module, include summary
- adjust test based on PRIVATE_COMMIT_EMAIL_OPT_IN so that it is clear what happens with the e-mail

See #10352
@nijel
Copy link
Member

nijel commented Nov 6, 2023

IMHO if you care about your e-mail privacy, you should read the terms of the service where you are putting it. But I've added a more prominent display of the TOS summary on registration in 3344f15, that should make it more obvious.

The setting applies on user creation, so it has to be site-wide, not per project.

But the e-mail configuration in the user profile could be indeed better, I will look into that.

@nijel nijel added the enhancement Adding or requesting a new feature. label Nov 6, 2023
@nijel nijel added this to the 5.2 milestone Nov 6, 2023
@nijel nijel self-assigned this Nov 6, 2023
nijel added a commit to nijel/weblate that referenced this issue Nov 6, 2023
- use radio instead of select to make all choices directly visible
  (there won't be much of them)
- clarify how each e-mail address is used (fixes WeblateOrg#10352)
- add shared text about e-mail verification
- rename "add e-mail" to "verify e-mail" as that better describes what
  it does
@nijel
Copy link
Member

nijel commented Nov 6, 2023

Pull request for profile changes: #10356

nijel added a commit to nijel/weblate that referenced this issue Nov 6, 2023
- use radio instead of select to make all choices directly visible
  (there won't be much of them)
- clarify how each e-mail address is used (fixes WeblateOrg#10352)
- add shared text about e-mail verification
- rename "add e-mail" to "verify e-mail" as that better describes what
  it does
nijel added a commit to nijel/weblate that referenced this issue Nov 6, 2023
- use radio instead of select to make all choices directly visible
  (there won't be much of them)
- clarify how each e-mail address is used (fixes WeblateOrg#10352)
- add shared text about e-mail verification
- rename "add e-mail" to "verify e-mail" as that better describes what
  it does
@Cerno-b
Copy link
Author

Cerno-b commented Nov 6, 2023

Thank you.

You're right of course, it's everyone's own fault for not reading the TOS, it's just that there are a lot of people who don't and it doesn't hurt to make things a bit more user-friendly in that regard.

Thanks for your effort about this issue 👍

nijel added a commit that referenced this issue Nov 6, 2023
- use radio instead of select to make all choices directly visible
  (there won't be much of them)
- clarify how each e-mail address is used (fixes #10352)
- add shared text about e-mail verification
- rename "add e-mail" to "verify e-mail" as that better describes what
  it does
Copy link

github-actions bot commented Nov 6, 2023

Thank you for your report; the issue you have reported has just been fixed.

  • In case you see a problem with the fix, please comment on this issue.
  • In case you see a similar problem, please open a separate issue.
  • If you are happy with the outcome, don’t hesitate to support Weblate by making a donation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Adding or requesting a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants