Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add throttling data to message and API #456

Merged
merged 4 commits into from
Aug 7, 2023

Conversation

m-aciek
Copy link
Contributor

@m-aciek m-aciek commented Aug 6, 2023

Proposed changes

Add throttling data to message and API.

Checklist

  • Lint and unit tests pass locally with my changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added documentation to describe my feature. (no docs for Python API)
  • I have squashed my commits into logic units.
  • I have described the changes in the commit messages.

@codecov
Copy link

codecov bot commented Aug 6, 2023

Codecov Report

Merging #456 (6f9cb2f) into main (088cfe8) will decrease coverage by 0.12%.
The diff coverage is 85.71%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #456      +/-   ##
==========================================
- Coverage   99.08%   98.97%   -0.12%     
==========================================
  Files           6        6              
  Lines        1645     1655      +10     
  Branches      215      217       +2     
==========================================
+ Hits         1630     1638       +8     
  Misses          8        8              
- Partials        7        9       +2     
Files Changed Coverage Δ
wlc/__init__.py 97.57% <83.33%> (-0.44%) ⬇️
wlc/test_base.py 94.89% <100.00%> (ø)
wlc/test_wlc.py 100.00% <100.00%> (ø)

@m-aciek m-aciek marked this pull request as draft August 7, 2023 00:34
@m-aciek
Copy link
Contributor Author

m-aciek commented Aug 7, 2023

mypy fails to recognize the existence of the docstring on the error class. (I've filed a ticket for that.) I'm going to add a cast as a workaround.

@m-aciek m-aciek marked this pull request as ready for review August 7, 2023 00:40
@nijel nijel merged commit 4d1c0a7 into WeblateOrg:main Aug 7, 2023
22 of 24 checks passed
@nijel
Copy link
Member

nijel commented Aug 7, 2023

Merged, thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants