Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

settings->openingbalances->getList calls get() without required parameters causing fatal error #108

Open
midweste opened this issue Dec 27, 2023 · 2 comments

Comments

@midweste
Copy link
Contributor

midweste commented Dec 27, 2023

getList calls $this->get() without required parameters:
https://github.com/Weble/ZohoBooksApi/blob/905b00d4a75b689a7f16dc1a5efb3f10a4b7c50e/src/Modules/Settings/OpeningBalances.php#L45C47-L45C47

    /**
     * @return Collection
     */
    public function getList($params = [])
    {
        return new Collection([$this->get()]);
    }


    /**
     * @param string $id
     * @param array $params
     * @return \Webleit\ZohoBooksApi\Models\Model
     */
    public function get ($id, array $params = [])
    {
        return parent::get($id, $params); // TODO: Change the autogenerated stub
    }
@midweste midweste changed the title settings->openingbalances->getList calls get() with no parameters causing fatal error settings->openingbalances->getList calls get() without required parameters causing fatal error Dec 27, 2023
@Skullbock
Copy link
Contributor

Thanks for the report. Can you send a PR with a proposed fix?

@midweste
Copy link
Contributor Author

Thanks for the report. Can you send a PR with a proposed fix?

Done #109

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants