Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BankTransactions module #120

Open
joopvanduin opened this issue Oct 1, 2024 · 1 comment
Open

BankTransactions module #120

joopvanduin opened this issue Oct 1, 2024 · 1 comment

Comments

@joopvanduin
Copy link

Thank you for the great library!

I have found 2 problems while using the BankTransactions module

  1. Changed returnvalue of function

    public function match($id, $data, $params = [])
    {
    $data = $this->client->post($this->getUrl() . '/uncategorized/' . $id . '/match', $data, $params);
    // Joop: 1-10-2024 Changed returnvalue to $data, it was $data['transactions_to_be_matched'], which doesn't exist
    return $data;
    }

  2. Added function:

    // Joop. 29-09-2024. Otherwise banktransaction_id would be used
    public function getApiKeyName()
    {
    return "transaction_id";
    }

All the best
Joop

@Skullbock
Copy link
Contributor

Thanks! Can you send a Pull Request with your proposed changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants