Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quick readme fix + new WebP and VGM patterns #294

Merged
merged 13 commits into from
Nov 17, 2024

Conversation

applecuckoo
Copy link
Contributor

@applecuckoo applecuckoo commented Aug 20, 2024

this PR is getting bigger and bigger as it is left unmerged, lol

Also, the VGM pattern should fix #180. There's no VGM test file as I'm not sure if there are any public domain/GPL v2 examples out there.

The Protobuf commits should fix #261 and fix #152.

@applecuckoo applecuckoo changed the title README: fix square bracket quick readme fix + new WebP pattern Aug 25, 2024
@applecuckoo applecuckoo changed the title quick readme fix + new WebP pattern quick readme fix + new WebP and VGM patterns Aug 28, 2024
@applecuckoo applecuckoo mentioned this pull request Aug 28, 2024
@applecuckoo
Copy link
Contributor Author

@WerWolv hey! Just a quick reminder ping to merge this and all the other PRs sitting around. Also, a couple of test file notes from me - I've made it tickable for ease of tracking:

  • I haven't put in a VGM sample due to potential copyright pitholes and stuff. The stuff at Battle of the Bits seems to be mostly CC BY-NC-SA, so I can't use that, and the Furnace tracker demos are all rights reserved, so that's out of the picture as well.
  • The protobuf test file is just full of zeros and doesn't really appear to be a 'real' protobuf wire, might be worth investigating

@WerWolv WerWolv merged commit bf94cb7 into WerWolv:master Nov 17, 2024
2 checks passed
@WerWolv
Copy link
Owner

WerWolv commented Nov 17, 2024

Thank you! Sorry for the huge delay...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants