Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to aiogram repo? :) #1

Open
Olegt0rr opened this issue Aug 15, 2021 · 4 comments
Open

Migrate to aiogram repo? :) #1

Olegt0rr opened this issue Aug 15, 2021 · 4 comments

Comments

@Olegt0rr
Copy link

I suggest you to add this code as a PR to aiogram repo. It will help more people there.

@WhiteMemory99
Copy link
Owner

WhiteMemory99 commented Aug 15, 2021

The current implementation is flawed as this middleware doesn't work with fast=False polling and webhooks. Thus, I don't think it would be appropriate to add this to the aiogram GitHub repo until I, or someone else, have time to make certain adjustments to this middleware.
Also, afaik, there is a better decision for catching media group out there written by someone else, although that one is a lot more complex than mine.

@Olegt0rr
Copy link
Author

I use similar solution with 1 sec latency and "typing..." - works good for me.

Could you share a link to "better solution" you mentioned above?

@WhiteMemory99
Copy link
Owner

I believe, this one is more refined in terms of its reliability.

@Olegt0rr
Copy link
Author

I believe, this one is more refined in terms of its reliability.

This code is not suitable for high loads, too many redundant actions and calls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants