Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Base URL is always fixed. It should change if we are logging in to wikiEducation Dashboard or outreach programs dashboard. #274

Open
ujjwalagrawal17 opened this issue Dec 11, 2019 · 5 comments
Labels
bug Something isn't working high-priority

Comments

@ujjwalagrawal17
Copy link
Member

Summary:

After Integration of Koin, the static baseUrl is changing but it seems like we are calling only outreach server APIs even if we login using wiki education dashboard.

Ideally, we should hit the APIs of the corresponding server to whom we logged in.

If we login using wiki education dashboard, all details including the courses, campaigns, stats displayed are wrong as they are of outreach dashboard server. Also, my dashboard API is failing in that case.

To fix the issue, we need to use Scope API in koin 2.0 while logging in to modify baseUrl.

Links:

Steps to reproduce:

Login Using Wiki Education Dashboard Page.

Would you like to work on the issue?
If no one picks it up, I will work on it.

@ujjwalagrawal17 ujjwalagrawal17 added bug Something isn't working help wanted labels Dec 11, 2019
@gconnect
Copy link
Collaborator

What's the API for outreach and wiki education dashboard?

@ujjwalagrawal17 ujjwalagrawal17 added high-priority-bug bug Something isn't working high-priority and removed bug Something isn't working high-priority-bug help wanted labels Dec 15, 2019
@ujjwalagrawal17 ujjwalagrawal17 pinned this issue Jan 15, 2020
@ujjwalagrawal17
Copy link
Member Author

@Darshpreet2000 @mistervaibhav , this is a high-priority bug. If anyone of you is free, feel free to try working on this.

@Darshpreet2000
Copy link
Contributor

I can try

@mistervaibhav
Copy link
Contributor

@Darshpreet2000 @mistervaibhav , this is a high-priority bug. If anyone of you is free, feel free to try working on this.

I want to resolve this issue, I have been learning Retrofit and Koin since a few days as these topics were new to me, still I find certain things in the app pretty overwhelming and hard to grasp. @ujjwalagrawal17 can you suggest some good resources , documentations or anything which will help me .
Thanks.

@ujjwalagrawal17
Copy link
Member Author

For Koin - https://www.matrixhive.com/koin-dependency-injection/ can help.
For Retrofit - https://square.github.io/retrofit/ the documentation is good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working high-priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants