Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI build failing #384

Open
Sheeri opened this issue Oct 26, 2020 · 0 comments
Open

CI build failing #384

Sheeri opened this issue Oct 26, 2020 · 0 comments
Labels
bug Something isn't working

Comments

@Sheeri
Copy link
Collaborator

Sheeri commented Oct 26, 2020

Describe the bug
CI build is failing and throwing the following issues:

❌ /Users/runner/work/o-fish-ios/o-fish-ios/o-fish-ios/Views/ReportFlow/AttachmentsView.swift:16:25: function declares an opaque return type, but has no return statements in its body from which to infer an underlying type
❌ /Users/runner/work/o-fish-ios/o-fish-ios/o-fish-ios/Views/Components/NotesListView.swift:19:13: type '()' cannot conform to 'View'; only struct/enum/class types can conform to protocols

** BUILD FAILED **
The following build commands failed:
CompileSwift normal arm64 /Users/runner/work/o-fish-ios/o-fish-ios/o-fish-ios/Views/ReportFlow/AttachmentsView.swift
CompileSwift normal arm64 /Users/runner/work/o-fish-ios/o-fish-ios/o-fish-ios/Views/Components/TextField/FocusableTextFieldAdapter.swift
CompileSwift normal arm64 /Users/runner/work/o-fish-ios/o-fish-ios/o-fish-ios/Views/Components/NotesListView.swift
CompileSwiftSources normal arm64 com.apple.xcode.tools.swift.compiler
(4 failures)

To Reproduce
Steps to reproduce the behavior:

  1. Go to a recent PR and look at the "Checks" tab - e.g. https://github.com/WildAid/o-fish-ios/pull/382/checks
  2. See error

Expected behavior
Should build cleanly.

Additional context
Looks like the issues were introduced in #375 (show new empty notes immediately, fix note deletion iOS issue)

@Sheeri Sheeri added the bug Something isn't working label Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant