From 5ae61c3ed2f120a0ae371da614da38adb22adc5c Mon Sep 17 00:00:00 2001 From: neoxpert <18628980+neoxpert@users.noreply.github.com> Date: Tue, 11 Jun 2024 21:04:20 +0200 Subject: [PATCH] Support builds for Electron v31 (#1200) * replace v8::CopyablePersistentTraits with v8::Global * add Electron v31 to build tasks --- .github/workflows/build.yml | 2 +- src/better_sqlite3.hpp | 2 +- src/util/macros.lzz | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 7b17b89a..bfdba506 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -20,7 +20,7 @@ env: NO_V18_NODE_BUILD_CMD: npx --no-install prebuild -r node -t 20.0.0 -t 22.0.0 --include-regex 'better_sqlite3.node$' # See https://www.electronjs.org/docs/latest/tutorial/electron-timelines#version-support-policy # Electron v25 EOL = 2023-12-05. v26 EOL = 2024-02-20. v27 EOL = 2024-04-16. v28 EOL = 2024-06-11. v29 EOL = 2024-08-20. - ELECTRON_BUILD_CMD: npx --no-install prebuild -r electron -t 26.0.0 -t 27.0.0 -t 28.0.0 -t 29.0.0 -t 30.0.0 --include-regex 'better_sqlite3.node$' + ELECTRON_BUILD_CMD: npx --no-install prebuild -r electron -t 26.0.0 -t 27.0.0 -t 28.0.0 -t 29.0.0 -t 30.0.0 -t 31.0.0 --include-regex 'better_sqlite3.node$' jobs: test: diff --git a/src/better_sqlite3.hpp b/src/better_sqlite3.hpp index 736e8754..44bef308 100644 --- a/src/better_sqlite3.hpp +++ b/src/better_sqlite3.hpp @@ -17,7 +17,7 @@ #include #include #line 31 "./src/util/macros.lzz" -template using CopyablePersistent = v8::Persistent>; +template using CopyablePersistent = v8::Global; #line 144 "./src/util/macros.lzz" void SetPrototypeGetter( v8::Isolate* isolate, diff --git a/src/util/macros.lzz b/src/util/macros.lzz index 31b9850c..4763b3c3 100644 --- a/src/util/macros.lzz +++ b/src/util/macros.lzz @@ -28,7 +28,7 @@ inline v8::Local InternalizedFromLatin1(v8::Isolate* isolate, const } #hdr -template using CopyablePersistent = v8::Persistent>; +template using CopyablePersistent = v8::Global; #end inline void SetFrozen(v8::Isolate* isolate, v8::Local ctx, v8::Local obj, CopyablePersistent& key, v8::Local value) { obj->DefineOwnProperty(ctx, key.Get(isolate), value, static_cast(v8::DontDelete | v8::ReadOnly)).FromJust();