Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handling path #91

Open
saiballo opened this issue Oct 14, 2023 · 2 comments
Open

handling path #91

saiballo opened this issue Oct 14, 2023 · 2 comments

Comments

@saiballo
Copy link

hello,

in current version cookie path is fixed to the value "/"

how about render it dynamic? something like this:

if (options.path) {
    cookie += '; path=' + options.path;
}
document.cookie = cookie + ';';

thank you
lorenzo

@guillaumepotier
Copy link
Member

Hi @saiballo,

Indeed that could be something we could override in options during instantiation.

Would you mind provide a Pull Request for that?

Best

@saiballo
Copy link
Author

I can try... I've never made a pull request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants