Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test building on mingw #182

Open
pombredanne opened this issue Jan 14, 2023 · 1 comment
Open

Test building on mingw #182

pombredanne opened this issue Jan 14, 2023 · 1 comment

Comments

@pombredanne
Copy link
Collaborator

As follow up to #175 we need to have some tests for the mingw build.

@pombredanne left a comment

Thanks!
Do you think we could also run the tests in the CI for this?
@nathaniel-daniel
Author
nathaniel-daniel commented Jan 14, 2023

Yes. The easiest method would involve installing an msys2 environment, installing the required packages, and building. I believe msys2 only works on Windows. How would you like that added to the test matrix? I assume you would want it added somehow to the "test_on_many_oses" action?

Adding to test_on_many_oses is the way.

@nathaniel-daniel
Copy link
Contributor

Would you imagine a mingw as part of the build matrix or as an extension of the windows tests? It would be hard to introduce to the build matrix as a new dimension, as it can only be tested on windows and many matrix combinations would not be valid. I also don't think it can be added as an os as it isn't really an os. Introducing it as a step that is run only on windows might be easier, but failures in either the windows or mingw build would fail the entire windows build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants