Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup to C Plugins #66

Merged
merged 6 commits into from
Oct 25, 2024
Merged

Cleanup to C Plugins #66

merged 6 commits into from
Oct 25, 2024

Commits on Oct 21, 2024

  1. Cleanup cplugin interface to fully use DeviceInfo_FFI and eliminate _…

    … prefix on some funcs
    
    - Remove dangling pointer to callback on cplugin unload
    - Remove need to allocate DeviceInfo in rust from a c plugin. We just let them use the FFI type and we copy the data over
    - Add some const qualifiers to things that should never be mutated
    simon-wh committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    7c95429 View commit details
    Browse the repository at this point in the history
  2. Further C plugin cleanup (#67)

    * Simplify CMakeLists for test_c_plugin
    It no longer needs linking against Rust code
    
    * Remove new_device_info & drop_device_info
    
    * Bump CPLUGIN_ABI_VERSION since everything's definitely incompatible now
    Sainan authored and simon-wh committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    304f92f View commit details
    Browse the repository at this point in the history
  3. Fix test (hopefully) (#68)

    * Fix "bindings changed"
    
    * Also run workflow on PR
    Sainan authored and simon-wh committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    2d77f3d View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    97f9885 View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2024

  1. Configuration menu
    Copy the full SHA
    e3384fe View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e7d36cf View commit details
    Browse the repository at this point in the history