-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test Polylang #2284
Comments
@cynthianorman feel free to leave your testing feedback here. |
Successfully installed on Learn WordPress local dev env |
Consider upgrading at some point to Pro |
We can select the languages we want to translate pages and posts to Note that showing the flag in the front end is optional |
You can create translated menus |
We assign a language to a page or post Note, we are able to do the same thing with courses |
It's important to know that we essentially build a separate set of pages/posts/taxonomies and corresponding menu for each language. For this reason, we would need to create the copied English page/post and designate it as French (for example) otherwise I don't believe this will work out for us. In other words, the copied English page/post would act as a placeholder until a translator would contribute the translation. https://drive.google.com/file/d/1ZLAMfGTc4nOa6Cl9Wdgo5BFpZEiBf4KR/view?usp=sharing |
@cynthianorman do you think you'd be able to update this issue with a summary of your findings, in a similar way as the WPML test? Edit, I've prepared the list in the comment below, so you just need to mark off the relevant items. This will allow me to prepare a summary comparison table of our test findings for the training team meeting on Thursday. |
Front-end requirements:
Back-end requirements:
|
ok @jonathanbossenger done |
Perfect, thank you so much! |
@sebastienserre I have been testing PolyLang this week, and I have encountered a blocker that I hope you can help resolve. Learn.WordPress.org uses Sensei LMS to manage our course content: https://wordpress.org/plugins/sensei-lms/ Sensei allows you to create course, and then create modules within the course and lessons within the modules: I am then able to navigate to individual lessons, and use the PolyLang feature to create different language versions of the individual lessons successfully: However, as soon as I assign the language and link the translated version of a lesson to the English one, the relationship between the module and the lesson is broken. If I navigate back to the course edit screen, the translated lesson does not appear anymore in the module. Are you able to assist in determining why this is happening? |
Hello @jonathanbossenger Here is a quick video where I show you What I'have found. I'm not used to use Sensei and at helpdesk we do not have so much request for this plugin, so I hope I'm matching your request. The "course" post meta seems to be synchronized between the same lesson in different language. This is due to a WPML compatibility because Polylang is compatible with the WPML API to understand plugin & theme compatibility made for this plugin. To stop this synchronization, you can create a
If some others post_meta needs to be ignored, then Of course, what is done thanks to the |
Hey @sebastienserre, no problem at all; I'm not used to PolyLang, so we're all figuring this out together. 😁
That does seem to be correct, so I will test your suggestion and report back with my findings. |
The initial sync is made by the Sensei LMS wpml-config.xml available at their root https://plugins.trac.wordpress.org/browser/sensei-lms/trunk/wpml-config.xml You can see lots of copied "custom fields" some other post metas are sync and may "break" your test. Adding some lines with Like WordPress with a child theme, Polylang will read first the plugin root wpml-config.xml file, then the parent theme one (if exists), then the child theme one, then check in |
Hello @sebastienserre. With the suggested wpml-config.xml config in place, I am still experiencing the problem. I have created a screen recording of what I am seeing, I hope this will help you understand what I'm experiencing. 2024-10-02.15-30-25.mp4 |
Hi @sebastienserre I wanted to follow up here, have you been able to look into this? Thanks |
Hello @jonathanbossenger |
@sebastienserre not a problem thanks for letting me know, I just wanted to make sure you got the message. |
Hello @jonathanbossenger Here are 2 videos (yes I'm not ready to contribute to learn team, I have problems to click on the correct button :) ) https://www.loom.com/share/7f4737cdf22342698e9b7198190beea8 I've set up a Twenty Twenty One child theme with the As you can see, I do not follow exactly the same steps you're following, but the result is I have a course translated in 2 languages. If you do not have the behaviour I have, I think a conflict is occurring... Does it work with Twenty Twenty One ? Where can I download the learn.wp.org theme to test it ? |
Ok, thanks @sebastienserre I will review the videos next week and check against the Learn theme. |
@sebastienserre thanks for the feedback. I can confirm that I can translate lessons the way you have shown. However, I'm seeing a weird thing that happens when I try to create lessons inside a module in the Course edit screen, which I think may be a Sensei related issue. I'm going to see if I can get some help with this. |
@kaitohm it looks like we might have a workable solution here. I was able to test it on a clean Sensei environment, so I just need to test it on the learn.wordpress.org local environment (which I plan to do today) and will report back here once that's done. |
Great news! Thanks for the update 👍 |
@kaitohm Ok, here is a recording of the process of translating lesson content: PolyLang.mp4In short, Polylang allows us to translate lesson content using the regular Lesson editing user interface and retain all the relevant course/module/lesson structures. All we need to ensure is the following:
Therefore, I propose we move ahead with the next step, which would be to arrange for the code review of PolyLang to be included in the .org infrastructure in order to use it on Learn. |
Thanks for the recording, @jonathanbossenger . This looks great! Please move forward with your suggestions above 👍 |
@adamwoodnz can we start the process of having the PolyLang and PolyLang Pro code reviewed for inclusion into .org? |
@jonathanbossenger Polylang is included inside the Polylang Pro |
Ah, thanks @sebastienserre. @adamwoodnz it looks like all we need to get reviewed then is the plugin in the wordpress.org repo. |
Sorry, which version are we planning to install on wordpress.org, Polylang or Polylang Pro? |
Hey @adamwoodnz, according to what @sebastienserre shared, we only need to test Polylang. |
Sounds like we'd need to install Pro, and it includes the base plugin |
Sorry @adamwoodnz I read the original message wrong. If we can test Polylang Pro please. I have a copy of the plugin code, let me know the best way to get it to you. |
We released Polylang Pro 3.6.5 last week to be OK with WP6.7. @jonathanbossenger you should be able to download it from your account at https:://polylang.pro/account. |
So given that we're installing the Pro version I wonder if we should add the code to this repository like we do for Sensei Pro. If so you could download the code and open a PR @jonathanbossenger. Then we can review that. This would mean it wouldn't be available for other .org sites, only Learn, which might be desirable. @dd32 what do you think? |
I'm happy to do that if that works best for everyone involved. |
Hello, I'm going to see with Polylang's founder if it's reasonable to expose our Pro plugin (Unique surce of revenue for our company) in a public Github repository. Regards |
@sebastienserre it might be helpful here to confirm if Learn actually needs the pro version of the plugin. As far as I can tell, all we need to be able to do is create translated versions of courses, modules, and lessons with support for a language switcher. Correct me if I am wrong, but this is part of the core plugin available on the .org directory. |
@jonathanbossenger Site Editor, block editor is managed by Polylang pro, not Polylang. |
Sorry, but to be clear; we use the block editor for Courses and Lessons, so does that mean we need Pro? I didn't quite appreciate that we would be open sourcing your Pro code with this approach 🤦 Thanks for checking, and making this possible. Dion is currently on leave, so I'd like to await his return and opinion on this. |
Yes you need Polylang Pro. |
Thanks for checking and sharing the update @sebastienserre. @adamwoodnz I will create the PR this week and ping you here once it's ready. |
Learn is deployed into the same network that all other WordPress.org sites are in, so the plugin would be available to them, just not activated. The main reason to include the Pro source in the GitHub repo is if you need it for local development sites of Learn, otherwise we can safely deploy it straight to WordPress.org without it going through this repo. That's why Sensei Pro is included AFAIK, because it was needed for local development and the free version didn't provide the same experience. If you can share the code with me when you've got it, I can run it against the internal plugins tooling to ensure that no issues are flagged. |
Just noting that I've run the latest version of Polylang Pro 3.6.5 through the scanners I have access to, and nothing is being flagged as needing extra review, so I consider this good to deploy. |
@jonathanbossenger if you could proceed with the PR I can add any necessary tooling changes for deployment, thanks all. |
Thanks, everyone. I'll create the PR and tag @adamwoodnz for the review. |
Front-end requirements:
Back-end requirements:
The text was updated successfully, but these errors were encountered: