-
-
Notifications
You must be signed in to change notification settings - Fork 470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Review how docblock class imports are handled #2358
Comments
I tend to favour FQNs in docblocks for two reasons:
Using FQNs in docblocks prevents issues in both cases. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I noticed that in the docblocks we are unsing FQCN when adding types to the parameters. We are also importing those at the top of the file.
In most of the editors, the editor is smart enough that it will know to what class/interface we are referring to.
So we should consider maybe shortening the FQCNs in the docblocks?
Example:
Could be written as:
As the
File
is imported at the top of the file.Thoughts?
The text was updated successfully, but these errors were encountered: