-
Notifications
You must be signed in to change notification settings - Fork 185
Eyes are not the same (f177 & f530) #392
Comments
This needs to be unzipped, and the folder contents added to /sources/svg Then agree to come to the next WordCamp Buffalo once it's announced |
Gridicons has similar icons, and I don't think they have this same issue. The 2 eye icons are the same, except for the diagonal line. Just providing in case it's helpful http://automattic.github.io/gridicons/ |
I've tried again to recompile these assets, and they still look like above. cc @field2 for a consult? |
Yeah, it looks like the code that Illustrator pushed out was in an incompatible format. I'm remaking the svg files and comparing them to the prior versions. |
Archive.zip |
Is this already fixed and can be closed @field2 ? |
I just installed the dashicons.ttf by downloading it from the master branch, and it looks like it is still messed up. @jasmussen , can you take a look at this? |
(Les yeux sans visage) |
It looks like this issue is affecting many of the new icons I just added. I think it's something wrong with grunt-webfont, see this issue: sapegin/grunt-webfont#390 |
This PR outlines the two eye-icons, and rebuilds them. This fixes #392. Of course the newly built TTF font also needs to be added to WordPress core, but as far as the Dashicons repo is concerned, it fixes that issue. It also updates a number of dependencies that were out of date. See packagge*json files.
I created a fix in #409. As you can see from the GIF there, the vectors for the two eye-icons are perfectly placed on top of each other, so if there is mis-alignment, it must be from CSS. |
This PR outlines the two eye-icons, and rebuilds them. This fixes #392. Of course the newly built TTF font also needs to be added to WordPress core, but as far as the Dashicons repo is concerned, it fixes that issue. It also updates a number of dependencies that were out of date. See packagge*json files.
Thanks @jasmussen 🙏 |
There are two Dashicons that include eyes in them, one open and one with a line through it. These eyes are not the same size, in the same position, or using the same stroke.
Toggling between the two icons makes for an inconsistent appearance.
Below is the New Password UI in WordPress Core. One eye is used for the Password field type, another for the Plaintext field type. Clicking Show/Hide toggles it. A painters eye will identify the difference right away, but I've also overlapped them with 50% opacity so the difference is more obvious:
The text was updated successfully, but these errors were encountered: