Skip to content
This repository has been archived by the owner on Jan 26, 2023. It is now read-only.

Eyes are not the same (f177 & f530) #392

Closed
JJJ opened this issue Nov 9, 2019 · 12 comments · Fixed by #393 or #409
Closed

Eyes are not the same (f177 & f530) #392

JJJ opened this issue Nov 9, 2019 · 12 comments · Fixed by #393 or #409
Labels

Comments

@JJJ
Copy link
Contributor

JJJ commented Nov 9, 2019

There are two Dashicons that include eyes in them, one open and one with a line through it. These eyes are not the same size, in the same position, or using the same stroke.

Toggling between the two icons makes for an inconsistent appearance.

Below is the New Password UI in WordPress Core. One eye is used for the Password field type, another for the Plaintext field type. Clicking Show/Hide toggles it. A painters eye will identify the difference right away, but I've also overlapped them with 50% opacity so the difference is more obvious:

eyes

@field2
Copy link
Contributor

field2 commented Nov 11, 2019

This needs to be unzipped, and the folder contents added to /sources/svg
Then run grunt and do a PR

Then agree to come to the next WordCamp Buffalo once it's announced

Archive.zip

@davewhitley
Copy link

davewhitley commented Nov 15, 2019

Gridicons has similar icons, and I don't think they have this same issue. The 2 eye icons are the same, except for the diagonal line. Just providing in case it's helpful http://automattic.github.io/gridicons/

Screen Shot 2019-11-15 at 1 43 15 PM
Screen Shot 2019-11-15 at 1 43 11 PM

@JJJ
Copy link
Contributor Author

JJJ commented Nov 15, 2019

May need to reopen this. I think something is wrong.

These two icons ended up pretty mangled in the font. They look OK in the sprite SVG though.

Screen Shot 2019-11-15 at 2 19 51 PM

Screen Shot 2019-11-15 at 2 22 02 PM

@JJJ
Copy link
Contributor Author

JJJ commented Nov 20, 2019

I've tried again to recompile these assets, and they still look like above. cc @field2 for a consult?

@field2
Copy link
Contributor

field2 commented Nov 20, 2019

Yeah, it looks like the code that Illustrator pushed out was in an incompatible format. I'm remaking the svg files and comparing them to the prior versions.

@field2 field2 reopened this Nov 20, 2019
@field2
Copy link
Contributor

field2 commented Nov 20, 2019

Archive.zip
Can you try again with the attached svgs? I ran a build on my local system with these and it fixed the issue in the font:
image

@Zodiac1978
Copy link
Collaborator

Is this already fixed and can be closed @field2 ?

@field2
Copy link
Contributor

field2 commented Mar 26, 2020

I just installed the dashicons.ttf by downloading it from the master branch, and it looks like it is still messed up. @jasmussen , can you take a look at this?
image

@field2
Copy link
Contributor

field2 commented Mar 27, 2020

(Les yeux sans visage)
The Eyes Are Not the Same
-Billy Idol
[sorry couldn't help myself]

@Zodiac1978 Zodiac1978 added the bug label Mar 28, 2020
@field2
Copy link
Contributor

field2 commented Apr 2, 2020

It looks like this issue is affecting many of the new icons I just added. I think it's something wrong with grunt-webfont, see this issue: sapegin/grunt-webfont#390

jasmussen added a commit that referenced this issue Apr 9, 2020
This PR outlines the two eye-icons, and rebuilds them. This fixes #392.

Of course the newly built TTF font also needs to be added to WordPress core, but as far as the Dashicons repo is concerned, it fixes that issue.

It also updates a number of dependencies that were out of date. See packagge*json files.
@jasmussen jasmussen mentioned this issue Apr 9, 2020
@jasmussen
Copy link
Collaborator

I created a fix in #409.

As you can see from the GIF there, the vectors for the two eye-icons are perfectly placed on top of each other, so if there is mis-alignment, it must be from CSS.

jasmussen added a commit that referenced this issue Apr 9, 2020
This PR outlines the two eye-icons, and rebuilds them. This fixes #392.

Of course the newly built TTF font also needs to be added to WordPress core, but as far as the Dashicons repo is concerned, it fixes that issue.

It also updates a number of dependencies that were out of date. See packagge*json files.
@JJJ
Copy link
Contributor Author

JJJ commented Apr 13, 2020

Thanks @jasmussen 🙏

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants