-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redo Media & Text Block to use nesting. #23356
Comments
We can only use a single InnerBlocks inside a parent block, and the Media&Text block already uses nested blocks for the content (not the image). So in order to do this, we'd have to introduce an intermediary internal block. It means we'd have to figure out how to transform from the existing blocks to this one... For me this is too complex and not worth the effort. |
My thinking is that if we are able to break down a Block into smaller pieces it would be good to do so. From how I understand this:
As the Block already uses innerBlocks for Text it is at present time difficult to also add the Image as an innerBlock based on the Image Block. It seems at present time Gutenberg is not ready to handle such a use case. Let's leave the issue open for now to gain additional feedback. |
I'm in agreement with @youknowriad here. The great thing about the Media+Text block is that it's more of a pattern than a block and provides users with a quick layout. If I wanted to recreate it, I could with the Columns block (bottom) as shown below. So while the Media+Text block isn't using a nested block for the image, I believe it's still valuable unless we want to remove the Core block in favor of a Media+Text pattern using Columns. |
I see the point of the Media & Text could actually just be two columns with content. Similar to a pattern. |
Is your feature request related to a problem? Please describe.
We should redo the Media & Text Block so it becomes a parent Block consisting of an Image Block and a Group Block.
Consistency. Handling of images should be the same in the Image Block, Gallery and the Media & Text Block.
The Image Block
Can add captions.
Has Styles
Alt Text
Image Size
Image dimensions
The Media & Text Block
Describe the solution you'd like
I would like to see the Media & Text Block become a parent block with a nested Image Block and a Group Block. Nested/Child Blocks have their own options in the sidebar. Clicking the parent Block shows the parent Block sidebar settings.
Advantage:
Creating a more flexible user experience.
Child Block have their own sidebar options.
Parent Block has its own sidebar settings.
Consistency between various blocks that use images.
Describe alternatives you've considered
To wait for additional options to be added to the Media & Text Block.
Associated Media & Text Block issues:
"Preserve caption when converting Image Block to Media & Text Block "
#22478
"Allow image styles on the 'Media & Text' block"
#20896
"Make editing image related blocks more consistent"
#18529
"Media & Text block: media dimensions"
#16853
"Image caption in Media & Text block"
#14604
"Media & Text: Insert from URL"
#14397
The text was updated successfully, but these errors were encountered: