Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Media & Text: Add caption support #67474

Open
wants to merge 8 commits into
base: trunk
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/reference-guides/core-blocks.md
Original file line number Diff line number Diff line change
Expand Up @@ -445,7 +445,7 @@ Set media and words side-by-side for a richer layout. ([Source](https://github.c
- **Name:** core/media-text
- **Category:** media
- **Supports:** align (full, wide), anchor, color (background, gradients, heading, link, text), interactivity (clientNavigation), spacing (margin, padding), typography (fontSize, lineHeight), ~~html~~
- **Attributes:** align, allowedBlocks, focalPoint, href, imageFill, isStackedOnMobile, linkClass, linkDestination, linkTarget, mediaAlt, mediaId, mediaLink, mediaPosition, mediaSizeSlug, mediaType, mediaUrl, mediaWidth, rel, useFeaturedImage, verticalAlignment
- **Attributes:** align, allowedBlocks, caption, focalPoint, href, imageFill, isStackedOnMobile, linkClass, linkDestination, linkTarget, mediaAlt, mediaId, mediaLink, mediaPosition, mediaSizeSlug, mediaType, mediaUrl, mediaWidth, rel, useFeaturedImage, verticalAlignment

## Unsupported

Expand Down
6 changes: 6 additions & 0 deletions packages/block-library/src/media-text/block.json
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,12 @@
"useFeaturedImage": {
"type": "boolean",
"default": false
},
"caption": {
"type": "rich-text",
"source": "rich-text",
"selector": "figcaption",
"role": "content"
}
},
"usesContext": [ "postId", "postType" ],
Expand Down
10 changes: 10 additions & 0 deletions packages/block-library/src/media-text/edit.js
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,7 @@ function attributesFromMedia( {
mediaLink: undefined,
href: undefined,
focalPoint: undefined,
caption: undefined,
} );
return;
}
Expand Down Expand Up @@ -128,6 +129,7 @@ function attributesFromMedia( {
mediaLink: media.link || undefined,
href: newHref,
focalPoint: undefined,
caption: media.caption,
} );
};
}
Expand Down Expand Up @@ -156,6 +158,7 @@ function MediaTextEdit( {
verticalAlignment,
allowedBlocks,
useFeaturedImage,
caption,
} = attributes;
const mediaSizeSlug = attributes.mediaSizeSlug || DEFAULT_MEDIA_SIZE_SLUG;

Expand All @@ -179,6 +182,9 @@ function MediaTextEdit( {
const featuredImageAlt = useFeaturedImage
? featuredImageMedia?.alt_text
: '';
const featuredImageCaption = useFeaturedImage
? featuredImageMedia?.caption?.rendered
: '';

const toggleUseFeaturedImage = () => {
setAttributes( {
Expand Down Expand Up @@ -483,6 +489,7 @@ function MediaTextEdit( {
refMedia={ refMedia }
enableResize={ blockEditingMode === 'default' }
toggleUseFeaturedImage={ toggleUseFeaturedImage }
setAttributes={ setAttributes }
{ ...{
focalPoint,
imageFill,
Expand All @@ -497,6 +504,9 @@ function MediaTextEdit( {
useFeaturedImage,
featuredImageURL,
featuredImageAlt,
caption: useFeaturedImage
? featuredImageCaption
: caption,
} }
/>
{ mediaPosition !== 'right' && <div { ...innerBlocksProps } /> }
Expand Down
5 changes: 5 additions & 0 deletions packages/block-library/src/media-text/index.php
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,11 @@ function render_block_core_media_text( $attributes, $content ) {
// in order to display the featured image.
$media_size_slug = isset( $attributes['mediaSizeSlug'] ) ? $attributes['mediaSizeSlug'] : 'full';
$image_tag = '<img class="wp-block-media-text__featured_image">';
$caption = get_the_post_thumbnail_caption();
$image_tag .= sprintf(
'<figcaption class="wp-element-caption">%1$s</figcaption>',
$caption
);
$content = preg_replace(
'/(<figure\s+id="' . preg_quote( $unique_id, '/' ) . '"\s+class="wp-block-media-text__media"\s*>)/',
'$1' . $image_tag,
Expand Down
11 changes: 11 additions & 0 deletions packages/block-library/src/media-text/media-container.js
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ import { media as icon } from '@wordpress/icons';
* Internal dependencies
*/
import { imageFillStyles } from './image-fill';
import { Caption } from '../utils/caption';

/**
* Constants
Expand Down Expand Up @@ -122,6 +123,8 @@ function MediaContainer( props, ref ) {
featuredImageURL,
featuredImageAlt,
refMedia,
caption,
setAttributes,
} = props;

const isTemporaryMedia = ! mediaId && isBlobURL( mediaUrl );
Expand Down Expand Up @@ -211,6 +214,14 @@ function MediaContainer( props, ref ) {
withIllustration
/>
) }
<Caption
attributes={ { caption } }
setAttributes={ setAttributes }
isSelected={ isSelected }
label={ __( 'Audio caption text' ) }
showToolbarButton={ isSelected }
readOnly={ useFeaturedImage }
/>
</ResizableBoxContainer>
);
}
Expand Down
29 changes: 22 additions & 7 deletions packages/block-library/src/media-text/save.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,12 @@ import clsx from 'clsx';
/**
* WordPress dependencies
*/
import { useInnerBlocksProps, useBlockProps } from '@wordpress/block-editor';
import {
RichText,
useInnerBlocksProps,
useBlockProps,
__experimentalGetElementClassName,
} from '@wordpress/block-editor';

/**
* Internal dependencies
Expand All @@ -33,6 +38,7 @@ export default function save( { attributes } ) {
href,
linkTarget,
rel,
caption,
} = attributes;
const mediaSizeSlug = attributes.mediaSizeSlug || DEFAULT_MEDIA_SIZE_SLUG;
const newRel = ! rel ? undefined : rel;
Expand All @@ -47,12 +53,21 @@ export default function save( { attributes } ) {
: {};

let image = mediaUrl ? (
<img
src={ mediaUrl }
alt={ mediaAlt }
className={ imageClasses || null }
style={ positionStyles }
/>
<>
<img
src={ mediaUrl }
alt={ mediaAlt }
className={ imageClasses || null }
style={ positionStyles }
/>
{ ! RichText.isEmpty( caption ) && (
<RichText.Content
className={ __experimentalGetElementClassName( 'caption' ) }
tagName="figcaption"
value={ caption }
/>
) }
</>
) : null;

if ( href ) {
Expand Down
7 changes: 7 additions & 0 deletions packages/block-library/src/media-text/style.scss
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,13 @@
&.has-media-on-the-right {
grid-template-columns: 1fr 50%;
}

// Supply caption styles to Media-Text blocks, even if the theme hasn't opted in.
// Reason being: the new markup, <figcaptions>, are not likely to be styled in the majority of existing themes,
// so we supply the styles so as to not appear broken or unstyled in those themes.
:where(figcaption) {
@include caption-style();
}
}

.wp-block-media-text.is-vertically-aligned-top {
Expand Down
6 changes: 4 additions & 2 deletions packages/block-library/src/media-text/transforms.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,14 @@ const transforms = {
{
type: 'block',
blocks: [ 'core/image' ],
transform: ( { alt, url, id, anchor } ) =>
transform: ( { alt, url, id, anchor, caption } ) =>
createBlock( 'core/media-text', {
mediaAlt: alt,
mediaId: id,
mediaUrl: url,
mediaType: 'image',
anchor,
caption,
} ),
},
{
Expand Down Expand Up @@ -104,11 +105,12 @@ const transforms = {
isMatch: ( { mediaType, mediaUrl } ) => {
return ! mediaUrl || mediaType === 'image';
},
transform: ( { mediaAlt, mediaId, mediaUrl, anchor } ) => {
transform: ( { mediaAlt, mediaId, mediaUrl, caption, anchor } ) => {
return createBlock( 'core/image', {
alt: mediaAlt,
id: mediaId,
url: mediaUrl,
caption,
anchor,
} );
},
Expand Down
3 changes: 2 additions & 1 deletion test/integration/fixtures/blocks/core__media-text.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,8 @@
"mediaType": "image",
"mediaWidth": 50,
"isStackedOnMobile": true,
"useFeaturedImage": false
"useFeaturedImage": false,
"caption": ""
},
"innerBlocks": [
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,8 @@
"mediaType": "image",
"mediaWidth": 50,
"isStackedOnMobile": true,
"useFeaturedImage": false
"useFeaturedImage": false,
"caption": ""
},
"innerBlocks": [
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,8 @@
"mediaWidth": 50,
"isStackedOnMobile": true,
"imageFill": true,
"useFeaturedImage": false
"useFeaturedImage": false,
"caption": ""
},
"innerBlocks": [
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,8 @@
"x": 0.84,
"y": 0.84
},
"useFeaturedImage": false
"useFeaturedImage": false,
"caption": ""
},
"innerBlocks": [
{
Expand Down
Loading