Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove patterns from the Quick Inserter to prevent misuse in block-specific contexts #67738

Open
wants to merge 3 commits into
base: trunk
Choose a base branch
from

Conversation

rohitmathur-7
Copy link
Contributor

@rohitmathur-7 rohitmathur-7 commented Dec 9, 2024

What?

Why?

  • We are removing Patterns from the quick inserter to prevent misuse in block-specific contexts.

How?

  • Set maxBlockPatterns to 0 which will help in not showing patterns in the quick inserter.

Testing Instructions

  • Open the block editor and add any block (e.g., Social Links).
  • Click the “+” button in the block toolbar to open the Quick Inserter.
  • Search for items, and observe that patterns are not included in the results.

Copy link

github-actions bot commented Dec 9, 2024

Warning: Type of PR label mismatch

To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.

  • Type-related labels to choose from: [Type] Automated Testing, [Type] Breaking Change, [Type] Bug, [Type] Build Tooling, [Type] Code Quality, [Type] Copy, [Type] Developer Documentation, [Type] Enhancement, [Type] Experimental, [Type] Feature, [Type] New API, [Type] Task, [Type] Technical Prototype, [Type] Performance, [Type] Project Management, [Type] Regression, [Type] Security, [Type] WP Core Ticket, Backport from WordPress Core, Gutenberg Plugin.
  • Labels found: .

Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task.

Copy link

github-actions bot commented Dec 9, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: rohitmathur-7 <rohitmathur7@git.wordpress.org>
Co-authored-by: talldan <talldanwp@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link
Contributor

@talldan talldan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rohitmathur-7 Thanks for working on this. This will be a really great change to get merged.

In testing I still see at least one issue to resolve.

The + appender button tooltip still says 'Add pattern' instead of 'Add block':
Screenshot 2024-12-10 at 4 13 13 pm

I think you can probably go through the code a bit more and remove instances of prioritizePatterns and related code, as that seems to be what causes the issue.

@rohitmathur-7
Copy link
Contributor Author

@rohitmathur-7 Thanks for working on this. This will be a really great change to get merged.

In testing I still see at least one issue to resolve.

The + appender button tooltip still says 'Add pattern' instead of 'Add block': Screenshot 2024-12-10 at 4 13 13 pm

I think you can probably go through the code a bit more and remove instances of prioritizePatterns and related code, as that seems to be what causes the issue.

Sure @talldan ,
Apologies for the delayed response 🙇‍♂️, and thank you so much for reviewing the code.
I’ll work on the suggested changes today. 🚀

@rohitmathur-7
Copy link
Contributor Author

Hii @talldan ,
I have updated the code to remove prioritizePatterns instances from wherever possible.
Can you please review the code again? 🙇
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants