-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove patterns from the Quick Inserter to prevent misuse in block-specific contexts #67738
base: trunk
Are you sure you want to change the base?
Remove patterns from the Quick Inserter to prevent misuse in block-specific contexts #67738
Conversation
Warning: Type of PR label mismatch To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task. |
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rohitmathur-7 Thanks for working on this. This will be a really great change to get merged.
In testing I still see at least one issue to resolve.
The +
appender button tooltip still says 'Add pattern' instead of 'Add block':
I think you can probably go through the code a bit more and remove instances of prioritizePatterns
and related code, as that seems to be what causes the issue.
Sure @talldan , |
Hii @talldan , |
What?
Why?
How?
Testing Instructions