Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Position: Refactor "Position" controls panel to use ToolsPanel instead of PanelBody #67967

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from

Conversation

yogeshbhutkar
Copy link
Contributor

@yogeshbhutkar yogeshbhutkar commented Dec 13, 2024

Fixes: #67950

What?

This PR introduces the usage of ToolsPanel instead of PanelBody inside the Position block support UI.

Why?

This PR is a part of #67813 which standardizes the usage of ToolsPanel inside Block Support UI.

How?

PanelBody is replaced with the corresponding ToolsPanel component.

Testing Instructions

  1. Insert a Group Block.
  2. Notice the presence of ToolsPanel component.
  3. Try to reset the updated values to test the reset functions.

Screencast

Screen.Recording.2024-12-13.at.4.03.43.PM.mov

@yogeshbhutkar yogeshbhutkar marked this pull request as ready for review December 13, 2024 10:48
Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: yogeshbhutkar <yogeshbhutkar@git.wordpress.org>
Co-authored-by: fabiankaegy <fabiankaegy@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@yogeshbhutkar yogeshbhutkar changed the title Refactor "Position" controls panel to use ToolsPanel instead of PanelBody Position: Refactor "Position" controls panel to use ToolsPanel instead of PanelBody Dec 13, 2024
@fabiankaegy fabiankaegy added [Type] Enhancement A suggestion for improvement. [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi labels Dec 13, 2024
Copy link
Member

@fabiankaegy fabiankaegy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before this update the position control also allowed you to update its value when multiple group blocks (blocks that support position) were selected. That code has been removed here.

For a single block this already works well. But we need to also handle multi block selection again :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor "Position" block support UI to use ToolsPanel instead of PanelBody
2 participants