Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor "Settings" panel of Navigation Item block to use ToolsPanel instead of PanelBody #67973

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

rinkalpagdar
Copy link
Contributor

@rinkalpagdar rinkalpagdar commented Dec 13, 2024

Part of #67813
Fixes #67947

Testing Instructions

  • Add navigation block
  • Click on the item link
  • Open the settings panel

Screenshots or screencast

Before After
before-toolspanel after-toolspanel

Copy link

github-actions bot commented Dec 13, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: rinkalpagdar <rinkalpagdar@git.wordpress.org>
Co-authored-by: fabiankaegy <fabiankaegy@git.wordpress.org>
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@fabiankaegy fabiankaegy added [Type] Enhancement A suggestion for improvement. [Block] Navigation Link Affects the Navigation Link Block labels Dec 13, 2024
@fabiankaegy
Copy link
Member

@rinkalpagdar Looks like the Linting GitHub Action Check is failing. Would you mind addressing that? :)

@Mamaduka
Copy link
Member

I see package-lock.json and linting changes unrelated to this refactoring.

See contribution guidelines for developer tool setup - https://developer.wordpress.org/block-editor/contributors/code/getting-started-with-code-contribution/#developer-tools.

Copy link
Member

@fabiankaegy fabiankaegy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the linting there are some additional notes here:

In this initial refactor we need to make sure that all settings that were present before this update are still always visible after the update. So every ToolsPanelItem needs to have isShownByDefault set on it

CleanShot.2024-12-13.at.15.48.48.mp4

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think there are actually any changes in this file needed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Navigation Link Affects the Navigation Link Block [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor "Settings" panel of Navigation Item block to use ToolsPanel instead of PanelBody
3 participants