Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempts aren't tracked in Mythic keystone dungeons #713

Open
rdw-software opened this issue Apr 13, 2024 · 5 comments
Open

Attempts aren't tracked in Mythic keystone dungeons #713

rdw-software opened this issue Apr 13, 2024 · 5 comments

Comments

@rdw-software
Copy link
Member

Source: WowAce

I got the new version and it's still not tracking it. I've been running it at low M+ keys and it's still not updating. I've tried to comment it out and track it Custom but it's still not counting. Weird.

I believe there were some old issues related to Mythic+ and even some partially-working experiments, but it's still relevant:

  • For items that support kill statistics, M+ is tracked all the same as long as the statistic works in both versions (e.g., Freehold)
  • However, at least one item - Quantum Courser - doesn't seem to support kill statistics and so it won't be tracked in M+ at all

As a starting point, a reliable and non-intrusive method of detecting M+ completions would have to be added. Later on, this could be generalized and be provided as a separate method of detection, e.g. ENCOUNTER (for ENCOUNTER_END events), SCENARIO (assuming M+ uses this event? TBD), or similar. Unfortunately, I can't test this ingame even if I blindly implemented such code.

For now, I see two avenues to make some headway and possibly support M+ properly in the future:

  1. Copy whatever code some of the more popular M+ tracking addons are using and pray that it works
  2. Someone can submit an /etrace event log, for both the completion and chest opening section

Looking into the first part should be relatively easy, so this is already actionable (I think).

@rdw-software
Copy link
Member Author

Current hypothesis:

  • Can track M+ completion via CHALLENGE_MODE_COMPLETED event
  • The dungeon itself could be detected via UI map ID or some other means (dungeon APIs)
  • This solution doesn't seem 100% clean, but it should work for all M+ dungeons

If this works, it could later be generalized and provided as a new method (similar to NPC, boss, etc.)

@rdw-software
Copy link
Member Author

rdw-software commented Aug 21, 2024

This mount might also later become available via M+: https://www.wowhead.com/item=225548/wicks-lead

Edit: And the quest starter for this one https://www.wowhead.com/item=221765/stonevault-mechsuit

There could be others, but I'm not in the loop. Should probably implement a prototype so that people can test by season 2?

@rdw-software rdw-software changed the title Attempts for Quantum Courser aren't tracked in Mythic keystone dungeons Attempts aren't tracked in Mythic keystone dungeons Sep 20, 2024
@rdw-software
Copy link
Member Author

rdw-software commented Sep 20, 2024

The new dungeon items should also be available from M+ runs, at least according to the journal. I'll generalize this issue.

@rdw-software
Copy link
Member Author

Based on /etrace logs provided by Ellezanor (Discord), there appears to be no specific completion event:

image

image

Tracking the Opening spell with tooltip scanning and differentiating based on map ID might then be the only viable option.

@rdw-software
Copy link
Member Author

Another option worth investigating: Popular M+ addons should have code that reliably tracks the end of the dungeon run.

https://www.curseforge.com/wow/search?page=1&pageSize=20&sortBy=popularity&class=addons&search=mythic+keystone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: It's finally happening! (WIP)
Development

No branches or pull requests

1 participant