Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to react-native-reanimated #83

Closed
dancixx opened this issue Dec 19, 2021 · 7 comments
Closed

Migrate to react-native-reanimated #83

dancixx opened this issue Dec 19, 2021 · 7 comments
Assignees
Labels
enhancement New feature or request

Comments

@dancixx
Copy link

dancixx commented Dec 19, 2021

Do you plan to migrate to the RN-Reanimated 2? Sometimes the check animation is freezing when the JS Thread is full.

@WrathChaos WrathChaos self-assigned this Dec 20, 2021
@WrathChaos WrathChaos added the enhancement New feature or request label Dec 20, 2021
@WrathChaos
Copy link
Owner

Hello @dancixx,

I actually really want to improve the bouncing logic and replace the react-native Animated one with reanimated 2 however I'm thinking about the dependency problem. What do you think about that?

@dancixx
Copy link
Author

dancixx commented Dec 24, 2021

I can understand your dilemma in the case of zero dependencies but for example, I use Reanimated2 everywhere and I think much more future forwarded like react-native animated API, by the way, you have access to the threads and the animations are much smoother and the new Reanimated 2 has support for 120 fps animations. I thought for a long time that I can avoid the Reanimated 2 but in bigger projects much better like the inbuilt API, but if you want to hold the library without any dependency then I can create a forked version with Reanimated 2 and function components.

@WrathChaos
Copy link
Owner

Maybe I can create another library with the reanimated 2, I love the library itself but zero dependencies is really cool to use. We also need to think about the other devs too. Probably another library and mentioning it on the README is a much better idea.

@mohammedelnady
Copy link

please don't migrate to reanimated it has many issues during debugger

@WrathChaos
Copy link
Owner

Hello @mohammedelnady,
I will re-write the react-native-bouncy-checkbox with reanimated v2 but on another separated library. You can still use this without any issue don't worry :)

@mohammedelnady
Copy link

thanks man

@WrathChaos
Copy link
Owner

We can continue with this issue: #90

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants