Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Definition of cs2_wo_timecorr #1257

Closed
dachengx opened this issue Sep 6, 2023 · 3 comments
Closed

Definition of cs2_wo_timecorr #1257

dachengx opened this issue Sep 6, 2023 · 3 comments

Comments

@dachengx
Copy link
Collaborator

dachengx commented Sep 6, 2023

The master branch currently says that cs2_wo_timecorr is

f'Corrected area of {peak_name} S2 before SEG/EE and elife corrections (s2 xy correction applied) [PE]'

straxen/straxen/plugins/events/corrected_areas.py

Line 201 in 2e9eaaa

result[f"{peak_type}cs2_wo_timecorr"] = (cs2_top_xycorr + cs2_bottom_xycorr) * elife_correction

But in the code(which was introduced from 388ce3a#diff-75af39866372953e59e003b61a91bed2bee9effbb8159dd6fc911bcd8e2142d6R738-R739), it is after elife correction applied.
@dachengx
Copy link
Collaborator Author

dachengx commented Sep 6, 2023 •
edited
Loading

I would change the code, but not the descriptions at the following PR.

@dachengx
Copy link
Collaborator Author

dachengx commented Sep 6, 2023

PR: #1258

@dachengx dachengx mentioned this issue Sep 6, 2023
Merged
4 tasks
@dachengx
Copy link
Collaborator Author

MISSION ACCOMPLISHED by #1260

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dachengx