Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is MongoUploader and MongoDownloader used? #136

Closed
dachengx opened this issue Oct 4, 2024 · 1 comment · Fixed by #138
Closed

Is MongoUploader and MongoDownloader used? #136

dachengx opened this issue Oct 4, 2024 · 1 comment · Fixed by #138
Assignees
@yuema137

Comments

@dachengx
Copy link
Contributor

dachengx commented Oct 4, 2024

They seem to be important in utilix:

utilix/utilix/__init__.py

Line 17 in bffe28c

from .mongo_files import MongoUploader, MongoDownloader, APIUploader, APIDownloader
.

But they are not used in code space of XENONnT: https://github.com/search?q=org%3AXENONnT+MongoDownloader&type=code&p=1.
@yuema137 yuema137 mentioned this issue Oct 7, 2024
Merged
@yuema137
Copy link
Contributor

yuema137 commented Oct 7, 2024

@dachengx Thanks. See #138
I have checked and think removing the implementation here is a good practice. That was probably a redundant definition at an early stage when people were testing.

@yuema137 yuema137 mentioned this issue Oct 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yuema137 yuema137

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove redundant mongo XENONnT/utilix
2 participants
@dachengx @yuema137