Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement] Prevent negative amount input #1063

Closed
1 task done
agodlevska opened this issue Sep 12, 2024 · 3 comments
Closed
1 task done

[Improvement] Prevent negative amount input #1063

agodlevska opened this issue Sep 12, 2024 · 3 comments
Assignees
Labels
bug Something isn't working medium Issue affecting one Tx / User / Chain

Comments

@agodlevska
Copy link

agodlevska commented Sep 12, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

The amount field allows the entry of negative values. Plus and minus are allowed to be entered into the amount field.

Screen.Recording.2024-09-12.at.11.08.39.mov

Expected Behavior

The minimum amount should be set to 0, and it should not be possible to enter negative values.

Steps To Reproduce

  1. Open https://preview.portalbridge.com/0af992dedf/
  2. Enter a negative amount with minus sign (eg. -2)

Environment

- OS: macOS Sonoma 14.6.1
- Wallet: MetaMask
- Browser: Google Chrome Version 128.0.6613.120 (Official Build) (x86_64)

Anything else?

No response

@agodlevska agodlevska added bug Something isn't working medium Issue affecting one Tx / User / Chain labels Sep 12, 2024
@agodlevska agodlevska changed the title [Improvement] Prevent negative amount input for transactions [Improvement] Prevent negative amount input using the arrow keys Sep 12, 2024
@Wesleyleung
Copy link

Also the arrow keys shouldn't exist, which I have filed an issue for here #1057

@agodlevska agodlevska changed the title [Improvement] Prevent negative amount input using the arrow keys [Improvement] Prevent negative amount input Sep 13, 2024
@agodlevska
Copy link
Author

agodlevska commented Sep 13, 2024

The ticket has been updated, and the section regarding arrow keys has been removed as they are not applicable.

@tsadovska
Copy link

Tested OK on https://preview.portalbridge.com/b1f3c5115d/.

  • arrow keys are no longer displayed
  • user cannot add negative amount
Screen.Recording.2024-09-18.at.21.33.01.mov

Ticket can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working medium Issue affecting one Tx / User / Chain
Projects
None yet
Development

No branches or pull requests

4 participants