-
-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate x.509 cert value is a valid certificate before inlining contents into signature #251
Comments
Can you provide a specific example of what application you need to interoperate with that requires the X.509 certificate to be absent? |
kislyuk
changed the title
Empty <ds:X509Data/> is added if cert is set to empty string in call to sign.
Validate x.509 cert value is a valid certificate before inlining contents into signature
Mar 23, 2024
My code was faulty and produced empty string for ca chain. The cert parameter was no cecked, so the undesired result. Will provide the example.... |
I see, thanks. Yes, we need some validation here to ensure the certificate string to be inserted is an actual X.509 certificate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
If you set cert parameter of sign call to empty string, signature will produce an empty ds:X509Data/ in KeyInfo and even ignore public key data. Removing cert parameter form sign call will produce problem #250
The text was updated successfully, but these errors were encountered: