Update GET TaxRates spec #579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PETOSS-386 |
|
Thanks for raising an issue, a ticket has been created to track your request |
0GH4J
reviewed
Jan 30, 2024
| - OAuth2: [accounting.settings, accounting.settings.read] | ||
| tags: | ||
| - Accounting | ||
| operationId: getTaxRates |
There was a problem hiding this comment.
@jvcudis - can you update the operationId to "getTaxRateByTaxType"? This is how the other GETs by a given field are labelled in the spec. Also, "getTaxRates" causes an error because it is already used as the operationId for GET /TaxRates
There was a problem hiding this comment.
@0GH4J - thanks for reviewing the PR 😄
I updated the operationId value as requested.
manishT72
requested changes
Feb 16, 2024
| "ProviderName": "Xero API Partner", | ||
| "DateTimeUTC": "\/Date(1550797359081)\/", | ||
| "TaxRates": [ | ||
| { |
There was a problem hiding this comment.
Could you please indent the example JSON?
manishT72
approved these changes
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's reported by users (see CX0014522641 CX ticket) that the TaxType query param is not working. This query param is not supported by the Accounting API. What is supported is record filtering which allows users to append the
TaxTypein the endpoint's URL to filter for TaxRate with specific TaxType.Does not work ->
/TaxRates?TaxType={TaxType}Works ->
/TaxRates/{TaxType}Description
TaxTypequery param in GET TaxRatesTaxRates/{TaxTypes}Release Notes
We need to make this change to avoid confusing users since I few have used
TaxTypeas query param.Screenshots (if appropriate):
Types of Changes