Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RWRoute] Yet more cleanup #1072

Closed
wants to merge 39 commits into from
Closed

[RWRoute] Yet more cleanup #1072

wants to merge 39 commits into from

Conversation

eddieh-xlnx
Copy link
Collaborator

@eddieh-xlnx eddieh-xlnx commented Sep 26, 2024 •
edited
Loading

  • RouteNode reduced from 80 bytes to 64 bytes
  • RouteNodeGraph.{preservedMap,nodesMap} (no longer ConcurrentHashMap-s) values' to be arrays to be sized no larger than number of base wires of its tile
  • SLR crossing optimizations and distance computation fixes
  • Various other optimizations

Base automatically changed from rwroute_cleanup to 2024.1.3 September 27, 2024 02:12
Base automatically changed from 2024.1.3 to master October 2, 2024 23:52
@eddieh-xlnx
Tighten TestRWRoute.testSLRCrossingNonTimingDriven()
1298a39 
Signed-off-by: Eddie Hung <eddie.hung@amd.com>
@eddieh-xlnx
[RWRoute] Tidy up, no functional change
a206c2c 
Signed-off-by: Eddie Hung <eddie.hung@amd.com>
@eddieh-xlnx
[RWRoute] Fix SLR crossing distance estimation
ccdddee 
Signed-off-by: Eddie Hung <eddie.hung@amd.com>
@eddieh-xlnx
Remove unused RouteNode.driverCounts; down from 80 -> 72 bytes
4c1546b 
Signed-off-by: Eddie Hung <eddie.hung@amd.com>
@eddieh-xlnx
Update another test
69a22c1 
Signed-off-by: Eddie Hung <eddie.hung@amd.com>
@eddieh-xlnx
Remove unused import
d8afb12 
Signed-off-by: Eddie Hung <eddie.hung@amd.com>
@eddieh-xlnx
[RouteNodeGraph] Limit size of preservedMap/nodesMap value array
ec288a1 
Signed-off-by: Eddie Hung <eddie.hung@amd.com>
@eddieh-xlnx
[PartialRouter] unpreserveNet() to return new NetWrapper
a3bc056 
Signed-off-by: Eddie Hung <eddie.hung@amd.com>
@eddieh-xlnx
[PartialRouter] When overused sinks found, unroute on top of unpreser…
008377f 
…ving

Signed-off-by: Eddie Hung <eddie.hung@amd.com>
@eddieh-xlnx
Add asserts, remove ripUp()
36c9e43 
Signed-off-by: Eddie Hung <eddie.hung@amd.com>

Conflicts:
	src/com/xilinx/rapidwright/rwroute/PartialRouter.java
@eddieh-xlnx
[RWRoute] ripUp() to not release exclusive sink nodes
728b983 
Signed-off-by: Eddie Hung <eddie.hung@amd.com>

Conflicts:
	src/com/xilinx/rapidwright/rwroute/PartialRouter.java
	src/com/xilinx/rapidwright/rwroute/RWRoute.java
@eddieh-xlnx
Fix spacing
fbccb34 
Signed-off-by: Eddie Hung <eddie.hung@amd.com>
@eddieh-xlnx
Fix broken cherry-pick
22decc1 
Signed-off-by: Eddie Hung <eddie.hung@amd.com>
@eddieh-xlnx
Remove commented out code
ad76a4e 
Signed-off-by: Eddie Hung <eddie.hung@amd.com>
@eddieh-xlnx
Sink is only exclusive if no alt sinks
fd88782 
Signed-off-by: Eddie Hung <eddie.hung@amd.com>
@eddieh-xlnx
RouteNode from 72 bytes to 64; use array/AtomicReferenceArray for ...
e82e56a 
preservedMap and nodesMap

Signed-off-by: Eddie Hung <eddie.hung@amd.com>
@eddieh-xlnx
Add and use Connection.hasAltSinks()
8c5c6e8 
Signed-off-by: Eddie Hung <eddie.hung@amd.com>
@eddieh-xlnx
Fix sink rip up, tidy
e91ed20 
Signed-off-by: Eddie Hung <eddie.hung@amd.com>
@eddieh-xlnx
Fix assertions for alternate sinks
0bb302b 
Signed-off-by: Eddie Hung <eddie.hung@amd.com>
@eddieh-xlnx
Use Net.addPIP() for trackChanges()
b5d16c7 
Signed-off-by: Eddie Hung <eddie.hung@amd.com>
@eddieh-xlnx
[DesignTools] Cleanup createCeSrRstPinsToVCC()
037584c 
Signed-off-by: Eddie Hung <eddie.hung@amd.com>
@eddieh-xlnx
[RouteNode] setBaseCost() to be more robust
3160382 
Signed-off-by: Eddie Hung <eddie.hung@amd.com>
@eddieh-xlnx
Mark zero-length nodes with downhill PIP as being inaccessible
e7b8d6e 
Signed-off-by: Eddie Hung <eddie.hung@amd.com>
@eddieh-xlnx
Only warn about RCLKs if timing-driven
ef66def 
Signed-off-by: Eddie Hung <eddie.hung@amd.com>
@eddieh-xlnx
Do not add as child if INACCESSIBLE
bf1593d 
Signed-off-by: Eddie Hung <eddie.hung@amd.com>
@eddieh-xlnx
Update golden values
6821a07 
Signed-off-by: Eddie Hung <eddie.hung@amd.com>
@eddieh-xlnx
[DesignTools] Fix createCeSrRstPinsToVCC() for US BRAMs
f9069d1 
Signed-off-by: Eddie Hung <eddie.hung@amd.com>
@eddieh-xlnx
Apply suggestions from code review
790e797 
Signed-off-by: eddieh-xlnx <eddie.hung@amd.com>
@eddieh-xlnx
[DesignTools] Add LDCE/LDPE to flop types that need site pins
d4e94b7 
Signed-off-by: Eddie Hung <eddie.hung@amd.com>
@eddieh-xlnx
Ignore rnodes created before iteration 0, make abandoning message cle…
07d8f12 
…arer

Signed-off-by: Eddie Hung <eddie.hung@amd.com>
@eddieh-xlnx
Merge branch 'master' into rwroute_cleanup2
ab908c2 
Conflicts:
	src/com/xilinx/rapidwright/design/DesignTools.java
	src/com/xilinx/rapidwright/rwroute/PartialRouter.java
	src/com/xilinx/rapidwright/rwroute/RouteNode.java
@eddieh-xlnx
RouteNodeGraph.allowRoutethru() to ignore NODE_PINFEED targets
d9927c2 
Signed-off-by: Eddie Hung <eddie.hung@amd.com>
@eddieh-xlnx
Add comment
e00bd91 
Signed-off-by: Eddie Hung <eddie.hung@amd.com>
@eddieh-xlnx
Merge branch 'signal_router_optimize' into rwroute_cleanup2
3bfcdf4 
Conflicts:
	src/com/xilinx/rapidwright/rwroute/RWRoute.java
	src/com/xilinx/rapidwright/rwroute/RouteNode.java
	src/com/xilinx/rapidwright/rwroute/RouteNodeGraph.java
	src/com/xilinx/rapidwright/rwroute/RouteNodeType.java
@eddieh-xlnx eddieh-xlnx changed the base branch from master to signal_router_optimize November 14, 2024 05:02
@eddieh-xlnx
Cleanup
1ebc503 
Signed-off-by: Eddie Hung <eddie.hung@amd.com>
@eddieh-xlnx
Reduce SLR crossing goldens
0cf3118 
Signed-off-by: Eddie Hung <eddie.hung@amd.com>
@eddieh-xlnx
Reduce one more
c207dbc 
Signed-off-by: Eddie Hung <eddie.hung@amd.com>
@eddieh-xlnx
More accurate message
0b57ffa 
Signed-off-by: Eddie Hung <eddie.hung@amd.com>
@eddieh-xlnx
Simplify and comment
062e4d9 
Signed-off-by: Eddie Hung <eddie.hung@amd.com>
@eddieh-xlnx eddieh-xlnx deleted the branch signal_router_optimize November 14, 2024 21:12
@eddieh-xlnx eddieh-xlnx mentioned this pull request Nov 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@eddieh-xlnx