Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RWRoute] Yet more cleanup #1072

Closed
wants to merge 39 commits into from
Closed

Commits on Oct 4, 2024

  1. Tighten TestRWRoute.testSLRCrossingNonTimingDriven()

    Signed-off-by: Eddie Hung <eddie.hung@amd.com>
    eddieh-xlnx committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    1298a39 View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2024

  1. [RWRoute] Tidy up, no functional change

    Signed-off-by: Eddie Hung <eddie.hung@amd.com>
    eddieh-xlnx committed Oct 5, 2024
    Configuration menu
    Copy the full SHA
    a206c2c View commit details
    Browse the repository at this point in the history
  2. [RWRoute] Fix SLR crossing distance estimation

    Signed-off-by: Eddie Hung <eddie.hung@amd.com>
    eddieh-xlnx committed Oct 5, 2024
    Configuration menu
    Copy the full SHA
    ccdddee View commit details
    Browse the repository at this point in the history
  3. Remove unused RouteNode.driverCounts; down from 80 -> 72 bytes

    Signed-off-by: Eddie Hung <eddie.hung@amd.com>
    eddieh-xlnx committed Oct 5, 2024
    Configuration menu
    Copy the full SHA
    4c1546b View commit details
    Browse the repository at this point in the history
  4. Update another test

    Signed-off-by: Eddie Hung <eddie.hung@amd.com>
    eddieh-xlnx committed Oct 5, 2024
    Configuration menu
    Copy the full SHA
    69a22c1 View commit details
    Browse the repository at this point in the history
  5. Remove unused import

    Signed-off-by: Eddie Hung <eddie.hung@amd.com>
    eddieh-xlnx committed Oct 5, 2024
    Configuration menu
    Copy the full SHA
    d8afb12 View commit details
    Browse the repository at this point in the history
  6. [RouteNodeGraph] Limit size of preservedMap/nodesMap value array

    Signed-off-by: Eddie Hung <eddie.hung@amd.com>
    eddieh-xlnx committed Oct 5, 2024
    Configuration menu
    Copy the full SHA
    ec288a1 View commit details
    Browse the repository at this point in the history
  7. [PartialRouter] unpreserveNet() to return new NetWrapper

    Signed-off-by: Eddie Hung <eddie.hung@amd.com>
    eddieh-xlnx committed Oct 5, 2024
    Configuration menu
    Copy the full SHA
    a3bc056 View commit details
    Browse the repository at this point in the history
  8. [PartialRouter] When overused sinks found, unroute on top of unpreser…

    …ving
    
    Signed-off-by: Eddie Hung <eddie.hung@amd.com>
    eddieh-xlnx committed Oct 5, 2024
    Configuration menu
    Copy the full SHA
    008377f View commit details
    Browse the repository at this point in the history
  9. Add asserts, remove ripUp()

    Signed-off-by: Eddie Hung <eddie.hung@amd.com>
    
    Conflicts:
    	src/com/xilinx/rapidwright/rwroute/PartialRouter.java
    eddieh-xlnx committed Oct 5, 2024
    Configuration menu
    Copy the full SHA
    36c9e43 View commit details
    Browse the repository at this point in the history
  10. [RWRoute] ripUp() to not release exclusive sink nodes

    Signed-off-by: Eddie Hung <eddie.hung@amd.com>
    
    Conflicts:
    	src/com/xilinx/rapidwright/rwroute/PartialRouter.java
    	src/com/xilinx/rapidwright/rwroute/RWRoute.java
    eddieh-xlnx committed Oct 5, 2024
    Configuration menu
    Copy the full SHA
    728b983 View commit details
    Browse the repository at this point in the history
  11. Fix spacing

    Signed-off-by: Eddie Hung <eddie.hung@amd.com>
    eddieh-xlnx committed Oct 5, 2024
    Configuration menu
    Copy the full SHA
    fbccb34 View commit details
    Browse the repository at this point in the history
  12. Fix broken cherry-pick

    Signed-off-by: Eddie Hung <eddie.hung@amd.com>
    eddieh-xlnx committed Oct 5, 2024
    Configuration menu
    Copy the full SHA
    22decc1 View commit details
    Browse the repository at this point in the history
  13. Remove commented out code

    Signed-off-by: Eddie Hung <eddie.hung@amd.com>
    eddieh-xlnx committed Oct 5, 2024
    Configuration menu
    Copy the full SHA
    ad76a4e View commit details
    Browse the repository at this point in the history
  14. Sink is only exclusive if no alt sinks

    Signed-off-by: Eddie Hung <eddie.hung@amd.com>
    eddieh-xlnx committed Oct 5, 2024
    Configuration menu
    Copy the full SHA
    fd88782 View commit details
    Browse the repository at this point in the history
  15. RouteNode from 72 bytes to 64; use array/AtomicReferenceArray for ...

    preservedMap and nodesMap
    
    Signed-off-by: Eddie Hung <eddie.hung@amd.com>
    eddieh-xlnx committed Oct 5, 2024
    Configuration menu
    Copy the full SHA
    e82e56a View commit details
    Browse the repository at this point in the history
  16. Add and use Connection.hasAltSinks()

    Signed-off-by: Eddie Hung <eddie.hung@amd.com>
    eddieh-xlnx committed Oct 5, 2024
    Configuration menu
    Copy the full SHA
    8c5c6e8 View commit details
    Browse the repository at this point in the history
  17. Fix sink rip up, tidy

    Signed-off-by: Eddie Hung <eddie.hung@amd.com>
    eddieh-xlnx committed Oct 5, 2024
    Configuration menu
    Copy the full SHA
    e91ed20 View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2024

  1. Fix assertions for alternate sinks

    Signed-off-by: Eddie Hung <eddie.hung@amd.com>
    eddieh-xlnx committed Oct 6, 2024
    Configuration menu
    Copy the full SHA
    0bb302b View commit details
    Browse the repository at this point in the history
  2. Use Net.addPIP() for trackChanges()

    Signed-off-by: Eddie Hung <eddie.hung@amd.com>
    eddieh-xlnx committed Oct 6, 2024
    Configuration menu
    Copy the full SHA
    b5d16c7 View commit details
    Browse the repository at this point in the history
  3. [DesignTools] Cleanup createCeSrRstPinsToVCC()

    Signed-off-by: Eddie Hung <eddie.hung@amd.com>
    eddieh-xlnx committed Oct 6, 2024
    Configuration menu
    Copy the full SHA
    037584c View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2024

  1. [RouteNode] setBaseCost() to be more robust

    Signed-off-by: Eddie Hung <eddie.hung@amd.com>
    eddieh-xlnx committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    3160382 View commit details
    Browse the repository at this point in the history
  2. Mark zero-length nodes with downhill PIP as being inaccessible

    Signed-off-by: Eddie Hung <eddie.hung@amd.com>
    eddieh-xlnx committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    e7b8d6e View commit details
    Browse the repository at this point in the history
  3. Only warn about RCLKs if timing-driven

    Signed-off-by: Eddie Hung <eddie.hung@amd.com>
    eddieh-xlnx committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    ef66def View commit details
    Browse the repository at this point in the history
  4. Do not add as child if INACCESSIBLE

    Signed-off-by: Eddie Hung <eddie.hung@amd.com>
    eddieh-xlnx committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    bf1593d View commit details
    Browse the repository at this point in the history
  5. Update golden values

    Signed-off-by: Eddie Hung <eddie.hung@amd.com>
    eddieh-xlnx committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    6821a07 View commit details
    Browse the repository at this point in the history
  6. [DesignTools] Fix createCeSrRstPinsToVCC() for US BRAMs

    Signed-off-by: Eddie Hung <eddie.hung@amd.com>
    eddieh-xlnx committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    f9069d1 View commit details
    Browse the repository at this point in the history
  7. Apply suggestions from code review

    Signed-off-by: eddieh-xlnx <eddie.hung@amd.com>
    eddieh-xlnx authored Oct 7, 2024
    Configuration menu
    Copy the full SHA
    790e797 View commit details
    Browse the repository at this point in the history
  8. [DesignTools] Add LDCE/LDPE to flop types that need site pins

    Signed-off-by: Eddie Hung <eddie.hung@amd.com>
    eddieh-xlnx committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    d4e94b7 View commit details
    Browse the repository at this point in the history
  9. Ignore rnodes created before iteration 0, make abandoning message cle…

    …arer
    
    Signed-off-by: Eddie Hung <eddie.hung@amd.com>
    eddieh-xlnx committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    07d8f12 View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2024

  1. Merge branch 'master' into rwroute_cleanup2

    Conflicts:
    	src/com/xilinx/rapidwright/design/DesignTools.java
    	src/com/xilinx/rapidwright/rwroute/PartialRouter.java
    	src/com/xilinx/rapidwright/rwroute/RouteNode.java
    eddieh-xlnx committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    ab908c2 View commit details
    Browse the repository at this point in the history
  2. RouteNodeGraph.allowRoutethru() to ignore NODE_PINFEED targets

    Signed-off-by: Eddie Hung <eddie.hung@amd.com>
    eddieh-xlnx committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    d9927c2 View commit details
    Browse the repository at this point in the history
  3. Add comment

    Signed-off-by: Eddie Hung <eddie.hung@amd.com>
    eddieh-xlnx committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    e00bd91 View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2024

  1. Merge branch 'signal_router_optimize' into rwroute_cleanup2

    Conflicts:
    	src/com/xilinx/rapidwright/rwroute/RWRoute.java
    	src/com/xilinx/rapidwright/rwroute/RouteNode.java
    	src/com/xilinx/rapidwright/rwroute/RouteNodeGraph.java
    	src/com/xilinx/rapidwright/rwroute/RouteNodeType.java
    eddieh-xlnx committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    3bfcdf4 View commit details
    Browse the repository at this point in the history
  2. Cleanup

    Signed-off-by: Eddie Hung <eddie.hung@amd.com>
    eddieh-xlnx committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    1ebc503 View commit details
    Browse the repository at this point in the history
  3. Reduce SLR crossing goldens

    Signed-off-by: Eddie Hung <eddie.hung@amd.com>
    eddieh-xlnx committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    0cf3118 View commit details
    Browse the repository at this point in the history
  4. Reduce one more

    Signed-off-by: Eddie Hung <eddie.hung@amd.com>
    eddieh-xlnx committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    c207dbc View commit details
    Browse the repository at this point in the history
  5. More accurate message

    Signed-off-by: Eddie Hung <eddie.hung@amd.com>
    eddieh-xlnx committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    0b57ffa View commit details
    Browse the repository at this point in the history
  6. Simplify and comment

    Signed-off-by: Eddie Hung <eddie.hung@amd.com>
    eddieh-xlnx committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    062e4d9 View commit details
    Browse the repository at this point in the history