Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RWRoute] Versal optimizations #1093

Merged
merged 70 commits into from
Nov 14, 2024

Commits on Nov 4, 2024

  1. Add optimization of signal routing

    Signed-off-by: Wenhao Lin <wenhao.lin@amd.com>
    WenhaoLin-AMD committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    f89c96e View commit details
    Browse the repository at this point in the history
  2. Merge new method into RoutingGraph.isAccessible()

    Signed-off-by: Eddie Hung <eddie.hung@amd.com>
    eddieh-xlnx committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    57f39df View commit details
    Browse the repository at this point in the history
  3. Fix typo

    Signed-off-by: Eddie Hung <eddie.hung@amd.com>
    eddieh-xlnx committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    74df324 View commit details
    Browse the repository at this point in the history
  4. Add TestNode.testNodeReachabilityVersal() to check assumptions

    Signed-off-by: Eddie Hung <eddie.hung@amd.com>
    eddieh-xlnx committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    3bf9cb9 View commit details
    Browse the repository at this point in the history
  5. Add NODE_CLE_OUTPUT too

    Signed-off-by: Eddie Hung <eddie.hung@amd.com>
    eddieh-xlnx committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    bf4d076 View commit details
    Browse the repository at this point in the history
  6. Expand TestNode.testNodeReachabilityUltraScale()

    Signed-off-by: Eddie Hung <eddie.hung@amd.com>
    eddieh-xlnx committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    1f8a9d3 View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2024

  1. More

    Signed-off-by: Eddie Hung <eddie.hung@amd.com>
    eddieh-xlnx committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    bba91e1 View commit details
    Browse the repository at this point in the history
  2. Add and use RouteNodeType.LOCAL

    Signed-off-by: Eddie Hung <eddie.hung@amd.com>
    eddieh-xlnx committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    4356b03 View commit details
    Browse the repository at this point in the history
  3. Merge RouteNodeType.PINBOUNCE into LOCAL; rename WIRE, PINFEED_{I,O}

    Signed-off-by: Eddie Hung <eddie.hung@amd.com>
    eddieh-xlnx committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    7e7015a View commit details
    Browse the repository at this point in the history
  4. LUT routethru fixes

    Signed-off-by: Eddie Hung <eddie.hung@amd.com>
    eddieh-xlnx committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    b9ff45f View commit details
    Browse the repository at this point in the history
  5. Add testNodeReachabilityVersal()

    Signed-off-by: Eddie Hung <eddie.hung@amd.com>
    eddieh-xlnx committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    aabab3c View commit details
    Browse the repository at this point in the history
  6. Support UltraScale

    Signed-off-by: Eddie Hung <eddie.hung@amd.com>
    eddieh-xlnx committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    9929603 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    e47cd18 View commit details
    Browse the repository at this point in the history
  8. Extend RouteNodeType.LOCAL to Versal

    Signed-off-by: Eddie Hung <eddie.hung@amd.com>
    eddieh-xlnx committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    9aba0ac View commit details
    Browse the repository at this point in the history
  9. Exclude Versal's NODE_IMUX/NODE_{CLE,INTF}_CTRL if not in RRG

    Signed-off-by: Eddie Hung <eddie.hung@amd.com>
    eddieh-xlnx committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    c197f08 View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2024

  1. Merge branch 'master' into signal_router_optimize

    Conflicts:
    	src/com/xilinx/rapidwright/rwroute/Connection.java
    	src/com/xilinx/rapidwright/rwroute/RWRoute.java
    	src/com/xilinx/rapidwright/rwroute/RouteNode.java
    	src/com/xilinx/rapidwright/rwroute/RouteNodeGraph.java
    	src/com/xilinx/rapidwright/rwroute/RouteNodeInfo.java
    	test/src/com/xilinx/rapidwright/device/TestNode.java
    eddieh-xlnx committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    9717cd4 View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2024

  1. More explanatory approach; no difference

    Signed-off-by: Eddie Hung <eddie.hung@amd.com>
    eddieh-xlnx committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    7274b33 View commit details
    Browse the repository at this point in the history
  2. Improvement?

    Signed-off-by: Eddie Hung <eddie.hung@amd.com>
    eddieh-xlnx committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    14955fe View commit details
    Browse the repository at this point in the history
  3. Cleanup

    Signed-off-by: Eddie Hung <eddie.hung@amd.com>
    eddieh-xlnx committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    56afd4b View commit details
    Browse the repository at this point in the history
  4. Update comments

    Signed-off-by: Eddie Hung <eddie.hung@amd.com>
    eddieh-xlnx committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    cac787e View commit details
    Browse the repository at this point in the history
  5. Add NODE_INTF_{CNODE,BNODE}

    Signed-off-by: Eddie Hung <eddie.hung@amd.com>
    eddieh-xlnx committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    ef4227c View commit details
    Browse the repository at this point in the history

Commits on Nov 12, 2024

  1. [TestNode] Expand testNodeReachabilityUltraScale

    Signed-off-by: Eddie Hung <eddie.hung@amd.com>
    eddieh-xlnx committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    cd631ac View commit details
    Browse the repository at this point in the history
  2. Expand testNodeReachabilityVersal too

    Signed-off-by: Eddie Hung <eddie.hung@amd.com>
    eddieh-xlnx committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    038aa80 View commit details
    Browse the repository at this point in the history
  3. UltraScale+: Sub-divide LOCALs into _EAST/_WEST and stick to sink's side

    Signed-off-by: Eddie Hung <eddie.hung@amd.com>
    eddieh-xlnx committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    77fa308 View commit details
    Browse the repository at this point in the history
  4. Re-add EXCLUSIVE_SINK (non-sided) for CTRL sinks

    Signed-off-by: Eddie Hung <eddie.hung@amd.com>
    eddieh-xlnx committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    6229dbe View commit details
    Browse the repository at this point in the history
  5. Support UltraScale

    Signed-off-by: Eddie Hung <eddie.hung@amd.com>
    eddieh-xlnx committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    74fdf59 View commit details
    Browse the repository at this point in the history
  6. Print

    Signed-off-by: Eddie Hung <eddie.hung@amd.com>
    eddieh-xlnx committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    a1dca37 View commit details
    Browse the repository at this point in the history
  7. Expand testNodeReachabilityVersal

    Signed-off-by: Eddie Hung <eddie.hung@amd.com>
    eddieh-xlnx committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    977b068 View commit details
    Browse the repository at this point in the history
  8. Do not error out for Versal

    Signed-off-by: Eddie Hung <eddie.hung@amd.com>
    eddieh-xlnx committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    967890d View commit details
    Browse the repository at this point in the history
  9. Fix failing assertions

    Signed-off-by: Eddie Hung <eddie.hung@amd.com>
    eddieh-xlnx committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    9a48765 View commit details
    Browse the repository at this point in the history
  10. Remove unused import

    Signed-off-by: Eddie Hung <eddie.hung@amd.com>
    eddieh-xlnx committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    95bba95 View commit details
    Browse the repository at this point in the history
  11. Fix another typo

    Signed-off-by: Eddie Hung <eddie.hung@amd.com>
    eddieh-xlnx committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    3a25ead View commit details
    Browse the repository at this point in the history
  12. Fix SLR crossings

    Signed-off-by: Eddie Hung <eddie.hung@amd.com>
    eddieh-xlnx committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    0d60f48 View commit details
    Browse the repository at this point in the history
  13. More Versal fixes

    Signed-off-by: Eddie Hung <eddie.hung@amd.com>
    eddieh-xlnx committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    d4e0ea5 View commit details
    Browse the repository at this point in the history
  14. Update testSLRCrossingNonTimingDriven golden values

    Signed-off-by: Eddie Hung <eddie.hung@amd.com>
    eddieh-xlnx committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    07935a4 View commit details
    Browse the repository at this point in the history
  15. Tidy up and comments

    Signed-off-by: Eddie Hung <eddie.hung@amd.com>
    eddieh-xlnx committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    bb9db76 View commit details
    Browse the repository at this point in the history
  16. Add a few more testcases

    Signed-off-by: Eddie Hung <eddie.hung@amd.com>
    eddieh-xlnx committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    9e7d383 View commit details
    Browse the repository at this point in the history
  17. [RWRoute] Non-verbose mode to print out nodes popped

    Signed-off-by: Eddie Hung <eddie.hung@amd.com>
    eddieh-xlnx committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    4f43cf5 View commit details
    Browse the repository at this point in the history
  18. Update comments/asserts

    Signed-off-by: Eddie Hung <eddie.hung@amd.com>
    eddieh-xlnx committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    7890b5a View commit details
    Browse the repository at this point in the history
  19. Clean up RouteNodeGraph.isAccessible()

    Signed-off-by: Eddie Hung <eddie.hung@amd.com>
    eddieh-xlnx committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    15b7453 View commit details
    Browse the repository at this point in the history
  20. Fixes for UltraScale

    Signed-off-by: Eddie Hung <eddie.hung@amd.com>
    eddieh-xlnx committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    b61a199 View commit details
    Browse the repository at this point in the history
  21. Skip another assert for Versal

    Signed-off-by: Eddie Hung <eddie.hung@amd.com>
    eddieh-xlnx committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    a937982 View commit details
    Browse the repository at this point in the history
  22. Configuration menu
    Copy the full SHA
    da6c175 View commit details
    Browse the repository at this point in the history
  23. Merge branch 'rwroute_east_west' into signal_router_optimize

    Conflicts:
    	src/com/xilinx/rapidwright/rwroute/RWRoute.java
    	src/com/xilinx/rapidwright/rwroute/RouteNodeGraph.java
    	src/com/xilinx/rapidwright/rwroute/RouteNodeInfo.java
    	test/src/com/xilinx/rapidwright/device/TestNode.java
    eddieh-xlnx committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    6f0b9ae View commit details
    Browse the repository at this point in the history
  24. Fix Versal assertion

    Signed-off-by: Eddie Hung <eddie.hung@amd.com>
    eddieh-xlnx committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    b07f2db View commit details
    Browse the repository at this point in the history
  25. Fix assertion

    Signed-off-by: Eddie Hung <eddie.hung@amd.com>
    eddieh-xlnx committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    90e8d80 View commit details
    Browse the repository at this point in the history
  26. Expand test

    Signed-off-by: Eddie Hung <eddie.hung@amd.com>
    eddieh-xlnx committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    bdf791f View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2024

  1. Apply Xilinx#1098 to Versal too

    Signed-off-by: Eddie Hung <eddie.hung@amd.com>
    eddieh-xlnx committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    c1e8274 View commit details
    Browse the repository at this point in the history
  2. Assign CNODEs to be LOCAL_{EAST,WEST} (opposite to name)

    Signed-off-by: Eddie Hung <eddie.hung@amd.com>
    eddieh-xlnx committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    50287fe View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    b048ef3 View commit details
    Browse the repository at this point in the history
  4. Fix merge

    Signed-off-by: Eddie Hung <eddie.hung@amd.com>
    eddieh-xlnx committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    f4df052 View commit details
    Browse the repository at this point in the history
  5. Resolve FIXMEs

    Signed-off-by: Eddie Hung <eddie.hung@amd.com>
    eddieh-xlnx committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    003a051 View commit details
    Browse the repository at this point in the history
  6. Restore comment

    Signed-off-by: Eddie Hung <eddie.hung@amd.com>
    eddieh-xlnx committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    c057226 View commit details
    Browse the repository at this point in the history
  7. Fix continue

    Signed-off-by: Eddie Hung <eddie.hung@amd.com>
    eddieh-xlnx committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    353775c View commit details
    Browse the repository at this point in the history
  8. On Versal, make all NODE_PINFEEDs RouteNodeType.LOCAL

    Signed-off-by: Eddie Hung <eddie.hung@amd.com>
    eddieh-xlnx committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    a9f5161 View commit details
    Browse the repository at this point in the history
  9. Handle NODE_INTF_CNODE too

    Signed-off-by: Eddie Hung <eddie.hung@amd.com>
    eddieh-xlnx committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    76bc5cc View commit details
    Browse the repository at this point in the history
  10. Add comment

    Signed-off-by: Eddie Hung <eddie.hung@amd.com>
    eddieh-xlnx committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    7b190bf View commit details
    Browse the repository at this point in the history
  11. Simplify if

    Signed-off-by: Eddie Hung <eddie.hung@amd.com>
    eddieh-xlnx committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    e877503 View commit details
    Browse the repository at this point in the history
  12. Introduce LOCAL_RESERVED

    Signed-off-by: Eddie Hung <eddie.hung@amd.com>
    eddieh-xlnx committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    ce90eb7 View commit details
    Browse the repository at this point in the history
  13. Allow INODE and PINBOUNCE either side of CTRL sink to be used

    Signed-off-by: Eddie Hung <eddie.hung@amd.com>
    eddieh-xlnx committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    1c2b471 View commit details
    Browse the repository at this point in the history
  14. Update comment

    Signed-off-by: Eddie Hung <eddie.hung@amd.com>
    eddieh-xlnx committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    5414206 View commit details
    Browse the repository at this point in the history
  15. Clearer names

    Signed-off-by: Eddie Hung <eddie.hung@amd.com>
    eddieh-xlnx committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    57ed051 View commit details
    Browse the repository at this point in the history
  16. Fix

    Signed-off-by: Eddie Hung <eddie.hung@amd.com>
    eddieh-xlnx committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    8c0acba View commit details
    Browse the repository at this point in the history
  17. Tidy up

    Signed-off-by: Eddie Hung <eddie.hung@amd.com>
    eddieh-xlnx committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    d1e843a View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2024

  1. Merge branch 'master' into signal_router_optimize

    Conflicts:
    	src/com/xilinx/rapidwright/rwroute/RouteNode.java
    eddieh-xlnx committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    fb08d82 View commit details
    Browse the repository at this point in the history
  2. Use RouteNodeInfo.getType() with ignoreLaguna param

    Signed-off-by: Eddie Hung <eddie.hung@amd.com>
    eddieh-xlnx committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    fc4499a View commit details
    Browse the repository at this point in the history
  3. Rename param to forceSink

    Signed-off-by: Eddie Hung <eddie.hung@amd.com>
    eddieh-xlnx committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    9768314 View commit details
    Browse the repository at this point in the history
  4. Address review comments

    Signed-off-by: Eddie Hung <eddie.hung@amd.com>
    eddieh-xlnx committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    7e5ff64 View commit details
    Browse the repository at this point in the history
  5. Fix polarity of assert

    Signed-off-by: Eddie Hung <eddie.hung@amd.com>
    eddieh-xlnx committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    ddbc814 View commit details
    Browse the repository at this point in the history
  6. Tidy

    Signed-off-by: Eddie Hung <eddie.hung@amd.com>
    eddieh-xlnx committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    025004b View commit details
    Browse the repository at this point in the history