Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass arguments to build_custom flow script #1039

Closed
bwintermann opened this issue Apr 12, 2024 · 2 comments
Closed

Pass arguments to build_custom flow script #1039

bwintermann opened this issue Apr 12, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@bwintermann
Copy link

Details

New behavior

Change the run-docker.sh script to accept any number of arguments for the build_custom option, so that these arguments can be passed along to the build script.

Motivation

If the build python script is supposed to take arguments (for example to switch which steps to execute, target fps, etc.) and the interactive docker session is not an option, the only possibility right now to do this would be to either create different build scripts depending on which behaviour is wanted (but this gets unwieldy quickly) or to for example pass those args as an environment variable, but this more of a workaround, and since the arguments after $3 are not used right now, it would be nice to pass them directly.

Parts of FINN affected

run-docker.sh

@bwintermann bwintermann added the enhancement New feature or request label Apr 12, 2024
@alexhornburg-xlnx
Copy link

This was added in #1217

@auphelia
Copy link
Collaborator

Thanks @alexhornburg-xlnx for adding this feature! I am closing the issue for now, but @bwintermann feel free to reopen or create a new issue if this doesn't solve it for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants