The NewV2board send DNS config

[Septrum101]

Hello @pocketW , V2board has sent this json to backend. I just add the block rules. So should we add DNS rules to the core instance?

{
    "server_port": 10000,
    "network": "grpc",
    "networkSettings": {
        "path": "ray",
        "headers": {
            "Host": "test.com"
        }
    },
    "tls": 1,
    "base_config": {
        "push_interval": 60,
        "pull_interval": 60
    },
    "routes": [
        {
            "id": 1,
            "match": "360.cn",
            "action": "block",
            "action_value": null
        },
        {
            "id": 2,
            "match": "netflix.com",
            "action": "dns",
            "action_value": "1.1.1.1"
        }
    ]
}

I see the core instance have those interface

Type() interface{}
Close() error
RequireFeatures(callback interface{}) error
AddFeature(feature features.Feature) error
GetFeature(featureType interface{}) features.Feature
Start() error

Could it be use GetFeature(featureType interface{}) to get exsit dns setting? And after add new DNS rules use AddFeature(feature features.Feature) to update DNS rules?

[pocketW]

Hi @thank243 , I think this feature is related to the routing management API in this PR XTLS/Xray-core/pull/412 . But I am not sure why this PR has not been merged. There is another issue discussing this features XTLS/Xray-core/issues/414.

From my opinions, I think we can replace the router with our customized route package like we did for dispatch. It could allow us add a management API for XrayR to call and modify the route.

[pocketW]

Another possible solution is to get route features from core using GetFeature and close it. Then init a new route features and add it back to the core using AddFeature

[Septrum101]

I will check it a few days.

[Septrum101]

@pocketW I just test those method you mentioned. It return *dns.DNS, but all the struct's key are private. Thus we cannot replace it directly unless we implement all DNS interface. It'll take a lot of time. So I give it up. LOL
I think we should add a dnsConfig in controller and ervery period check compare the new and old dnsConfig, if changed, we can build a new DNSConfig{} directly replace whole dns in the core.instance?

[pocketW]

We can copy the dns package and make all the struct's key accessable. Then we can register this customized dns in here to replace the old one like we did for dispatcher.

Another choice is to directly replace whole dns in core.instance. I think the GetFeature and AddFeature I mentioned above might help.

[Septrum101]

I'm considering whether the remote DNS should override the local. If override, the feat will be easy to implement, else I should add local DNS to controller.