Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Ars Nouveau 'Touch' Form XP Gain #1

Open
VanyaBaou opened this issue Mar 14, 2022 · 1 comment
Open

[BUG] Ars Nouveau 'Touch' Form XP Gain #1

VanyaBaou opened this issue Mar 14, 2022 · 1 comment

Comments

@VanyaBaou
Copy link

Describe the bug
Ars Nouveau 'Touch' form spells still give XP when you don't successfully cast the spell

To Reproduce
Steps to reproduce the behavior:
Set Spell to "Touch" "Harm"
Right-Click looking at the air to cast spell

Expected behavior
No experience should be gained

Screenshots
https://i.imgur.com/hL8sDSH.png

Game Details (please complete the following information):

  • MC Version: 1.16.5
  • Forge Version: 36.2.23
  • PMMO Bridge Version: 1.0.6
  • PMMO Version: 3.67.4
@VanyaBaou VanyaBaou changed the title [BUG] [BUG] Ars Nouveau 'Touch' Form XP Gain Mar 14, 2022
@XxInvictus
Copy link
Owner

This one is a little bit screwy. I would stand to say that it is not an issue with PMMOBridge but an issue with Ars Nouveau.

All this mod is doing is listening for events of type SpellCastEvent from Ars Nouveau then doing the relevant XP actions. I would think that these events should not be fired if the spell was not successful and I cannot find a good replacement event in their API that might be able to replace this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants