Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible solution for rom hacks sharing same ID of original rom but with different custom banner: pass the ball to the user #21

Open
Yrouel opened this issue Apr 28, 2022 · 1 comment

Comments

@Yrouel
Copy link

Yrouel commented Apr 28, 2022

I just made a banner for both New Super Mario Bros. and its rom hack Newer Super Mario Bros. DS the latter however shares the same ID of the original rom so the generator wouldn't be able to differentiate.
My proposal for these specific somewhat edge cases would be to add the other assets in a folder called ID.1 (in this case it would've been A2D.1) and if the generator sees the presence of multiple assets it can just pop the question to the user.
Something like "it seems this rom has multiple assets available, it typically means the alternate asset is for a rom hack, if you are unsure proceed with the default"

I think it's acceptable to just ask the user given the niche nature of this issue

@lifehackerhansol
Copy link
Member

This isn't a bad idea. I'll think about this. I'm not too certain how I should implement it server-side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants