Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mistake: ar(1) vs ar(5) in Win #10

Open
theovincent opened this issue Mar 27, 2022 · 0 comments
Open

Mistake: ar(1) vs ar(5) in Win #10

theovincent opened this issue Mar 27, 2022 · 0 comments

Comments

@theovincent
Copy link

theovincent commented Mar 27, 2022

Hi, I am currently working on the paper that you published with this repository.

By looking at your Notebooks, I realized that, for the search method Win, the results shown in the paper for ar(1) are actually the results for ar(5). Indeed, in TEP_experiment_with_NAB_metric.ipynb and in SKAB_experiment.ipynb the models that are tried are:

models = (
    {'cost':'ar', 'params':{'order':1}, 'width':10},
    {'cost':'ar', 'params':{'order':1}, 'width':15},
    {'cost':'ar', 'params':{'order':5}, 'width':20},
    {'cost':'mahalanobis', 'params':{}, 'width':10},
    {'cost':'mahalanobis', 'params':{}, 'width':15},
    {'cost':'mahalanobis', 'params':{}, 'width':20},
    {'cost':'l1', 'params':{}, 'width':10},
    {'cost':'l1', 'params':{}, 'width':15},
    {'cost':'l1', 'params':{}, 'width':20},
    {'cost':'l2', 'params':{}, 'width':10},
    {'cost':'l2', 'params':{}, 'width':15},
    {'cost':'l2', 'params':{}, 'width':20},
#     {'cost':'linear', 'params':{}, 'width':10},
#     {'cost':'linear', 'params':{}, 'width':40},
#     {'cost':'linear', 'params':{}, 'width':100}
#     {'model':'rbf', 'params':{}, 'width':40},
#     {'model':'rbf', 'params':{}, 'width':100},
)

Hence, the model ar(1) with width=20 is never tried. In the paper, the results for the model ar(5) can be found.

I have done this little change in a forked repository and ran the experiments again.

ps: I had a lot of fun working on your paper. Thanks a lot for your work and your interesting ideas :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant